Skip to content

Remove duplication in ServletWebServerFactoryAutoConfigurationTests and DispatcherServletAutoConfigurationTests #44207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wilkinsona opened this issue Feb 11, 2025 · 0 comments
Closed

Remove duplication in ServletWebServerFactoryAutoConfigurationTests and DispatcherServletAutoConfigurationTests #44207

wilkinsona opened this issue Feb 11, 2025 · 0 comments
Assignees
@wilkinsona
Labels
type: task A general task
Milestone
3.3.9

Comments

@wilkinsona
Copy link
Member

ServletWebServerFactoryAutoConfigurationTests and DispatcherServletAutoConfigurationTests both contain tests that relate to dispatcher servlet registration and the logic in DefaultDispatcherServletCondition. Simplify things by moving all tests related to dispatcher servlet auto-configuration into DispatcherServletAutoConfigurationTests and removing any duplicate tests. This will also improve the separation of ServletWebServerFactoryAutoConfigurationTests which shouldn't know anything about Spring MVC.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilkinsona wilkinsona

Labels
type: task A general task
Projects
None yet
Milestone
3.3.9
Development

No branches or pull requests
1 participant
@wilkinsona