Skip to content

Update pull request workflow to use build action #42573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wilkinsona opened this issue Oct 9, 2024 · 1 comment
Closed

Update pull request workflow to use build action #42573

wilkinsona opened this issue Oct 9, 2024 · 1 comment
Labels
type: task A general task
Milestone
3.2.11

Comments

@wilkinsona
Copy link
Member

We clean them up for our main builds so we should do the same for PRs.
@wilkinsona wilkinsona added the type: task A general task label Oct 9, 2024
@wilkinsona wilkinsona added this to the 3.2.x milestone Oct 9, 2024
@wilkinsona wilkinsona changed the title Clean up large packages before running pull request builds Update pull request workflow to use build action Oct 10, 2024
@wilkinsona
Copy link
Member Author

Rather than updating the PR-specific workflow to align it with the other workflows, it would be easier to keep things in sync if it used the shared build action instead. As part of this, we'll have to add an input for whether or not Gradle's cache is read-only. We default that to true as we don't want PR builds to be able to add things to the GitHub Actions cache. We then set it to false in our CI, deployment, and release workflows so that they can make use of GitHub Actions' caching.

This was referenced Oct 10, 2024
Closed
Closed
@wilkinsona wilkinsona modified the milestones: 3.2.x, 3.2.11 Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: task A general task
Projects
None yet
Milestone
3.2.11
Development

No branches or pull requests
1 participant
@wilkinsona