Skip to content

Test fails after update 2.6.4 to 2.6.5 #30458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
datengaertnerei opened this issue Mar 29, 2022 · 2 comments
Closed

Test fails after update 2.6.4 to 2.6.5 #30458

datengaertnerei opened this issue Mar 29, 2022 · 2 comments
Labels
status: duplicate A duplicate of another issue

Comments

@datengaertnerei
Copy link

I am working on an OSS project at https://github.com/datengaertnerei/test-data-service

During one of the regular updates of Spring Boot dependency by Renovate Bot (2.6.4 to 2.6.5) one test failes and the PR was stopped. Tested manually the Maven build is successful with skipped tests and the service works fine even with that endpoint of the failed test.

Log excerpt from Maven build

org.springframework.dao.InvalidDataAccessApiUsageException: Parameter value [\] did not match expected type [java.lang.String (n/a)]; nested exception is java.lang.IllegalArgumentException: Parameter value [\] did not match expected type [java.lang.String (n/a)]
	at com.datengaertnerei.test.dataservice.junit.TestDataServiceApiTests.shouldReturnRandomPersonForArea(TestDataServiceApiTests.java:170)
Caused by: java.lang.IllegalArgumentException: Parameter value [\] did not match expected type [java.lang.String (n/a)]
	at com.datengaertnerei.test.dataservice.junit.TestDataServiceApiTests.shouldReturnRandomPersonForArea(TestDataServiceApiTests.java:170)

The failed method call at line 170 is result = restController.personForPostcode("20", AgeRange.ALL);

The called method is

	/**
	 * @param postalCode postalCode
	 * @param age age
	 * @return random person with a valid german postal address within the given postal code (zip) area (1-5 digits)
	 */
	@GetMapping(value = "/person/postalcode/{postalcode}")
	@Operation(summary = "random person with a valid german postal address within the given postal code (zip) area (1-5 digits)")
	@ApiResponse(responseCode = "200", description = "OK")
	@ApiResponse(responseCode = "400", description = "Bad Request", content = @Content())
	public Person personForPostcode(
			@Parameter(description = "the postal code to look for random postal address", required = true) @PathVariable("postalcode") String postalCode,
			@RequestParam(required = false) AgeRange age) {
		if (null == age) {
			return personGen.createRandomPersonInArea(postalCode, AgeRange.ALL);
		} else {
			return personGen.createRandomPersonInArea(postalCode, age);
		}
	}

There is a second very similar test that works just fine. So this is a low priority issue but maybe there is a quick fix.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 29, 2022
@knoobie
Copy link

knoobie commented Mar 29, 2022

@bclozel
Copy link
Member

bclozel commented Mar 29, 2022

Closing as a duplicate of #30454

@bclozel bclozel closed this as completed Mar 29, 2022
@bclozel bclozel added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Development

No branches or pull requests

4 participants