Skip to content

Add DeferredLogFactory support #22496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
philwebb opened this issue Jul 22, 2020 · 0 comments
Closed

Add DeferredLogFactory support #22496

philwebb opened this issue Jul 22, 2020 · 0 comments
Assignees
@philwebb
Labels
type: enhancement A general enhancement
Milestone
2.4.0-M2

Comments

@philwebb
Copy link
Member

Our DeferredLog class currently requires that the switchTo method is called as soon as the real log is available. This makes it hard for a class to use the DeferredLog without also being aware of when it can switch.

We should add a DeferredLogFactory interface that can be injected into classes that need to perform deferred logging, but don't necessarily know when they can switch to the real log.
@philwebb philwebb added this to the 2.4.x milestone Jul 22, 2020
@philwebb philwebb added the type: enhancement A general enhancement label Jul 22, 2020
@philwebb philwebb self-assigned this Jul 22, 2020
@philwebb philwebb mentioned this issue Jul 22, 2020
Closed
20 tasks
@philwebb philwebb modified the milestones: 2.4.x, 2.4.0-M2 Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philwebb philwebb

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.4.0-M2
Development

No branches or pull requests
1 participant
@philwebb