Skip to content

Commit fdf2f20

Browse files
committed
Merge branch '3.3.x'
Closes gh-41226
2 parents d411d43 + 6d0c68f commit fdf2f20

File tree

2 files changed

+63
-1
lines changed

2 files changed

+63
-1
lines changed

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/embedded/jetty/JettyEmbeddedWebAppContext.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@ protected ServletHandler newServletHandler() {
3838
}
3939

4040
void deferredInitialize() throws Exception {
41-
((JettyEmbeddedServletHandler) getServletHandler()).deferredInitialize();
41+
JettyEmbeddedServletHandler handler = (JettyEmbeddedServletHandler) getServletHandler();
42+
getContext().call(handler::deferredInitialize, null);
4243
}
4344

4445
private static final class JettyEmbeddedServletHandler extends ServletHandler {

spring-boot-project/spring-boot/src/test/java/org/springframework/boot/web/servlet/server/AbstractServletWebServerFactoryTests.java

Lines changed: 61 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040
import java.util.Date;
4141
import java.util.EnumSet;
4242
import java.util.HashMap;
43+
import java.util.HashSet;
4344
import java.util.LinkedHashMap;
4445
import java.util.List;
4546
import java.util.Locale;
@@ -65,6 +66,7 @@
6566
import jakarta.servlet.FilterChain;
6667
import jakarta.servlet.FilterConfig;
6768
import jakarta.servlet.GenericServlet;
69+
import jakarta.servlet.ServletConfig;
6870
import jakarta.servlet.ServletContext;
6971
import jakarta.servlet.ServletContextEvent;
7072
import jakarta.servlet.ServletContextListener;
@@ -1366,6 +1368,26 @@ void startedLogMessageWithMultiplePorts() {
13661368
+ " \\(http(/1.1)?\\), [0-9]+ \\(http(/1.1)?\\) with context path '/'");
13671369
}
13681370

1371+
@Test
1372+
void servletComponentsAreInitializedWithTheSameThreadContextClassLoader() {
1373+
AbstractServletWebServerFactory factory = getFactory();
1374+
ThreadContextClassLoaderCapturingServlet servlet = new ThreadContextClassLoaderCapturingServlet();
1375+
ThreadContextClassLoaderCapturingFilter filter = new ThreadContextClassLoaderCapturingFilter();
1376+
ThreadContextClassLoaderCapturingListener listener = new ThreadContextClassLoaderCapturingListener();
1377+
this.webServer = factory.getWebServer((context) -> {
1378+
context.addServlet("tcclCapturingServlet", servlet).setLoadOnStartup(0);
1379+
context.addFilter("tcclCapturingFilter", filter);
1380+
context.addListener(listener);
1381+
});
1382+
this.webServer.start();
1383+
assertThat(servlet.contextClassLoader).isNotNull();
1384+
assertThat(filter.contextClassLoader).isNotNull();
1385+
assertThat(listener.contextClassLoader).isNotNull();
1386+
assertThat(new HashSet<>(
1387+
Arrays.asList(servlet.contextClassLoader, filter.contextClassLoader, listener.contextClassLoader)))
1388+
.hasSize(1);
1389+
}
1390+
13691391
protected Future<Object> initiateGetRequest(int port, String path) {
13701392
return initiateGetRequest(HttpClients.createMinimal(), port, path);
13711393
}
@@ -1822,4 +1844,43 @@ public boolean isTrusted(X509Certificate[] chain, String authType) {
18221844

18231845
}
18241846

1847+
static class ThreadContextClassLoaderCapturingServlet extends HttpServlet {
1848+
1849+
private ClassLoader contextClassLoader;
1850+
1851+
@Override
1852+
public void init(ServletConfig config) throws ServletException {
1853+
this.contextClassLoader = Thread.currentThread().getContextClassLoader();
1854+
}
1855+
1856+
}
1857+
1858+
static class ThreadContextClassLoaderCapturingListener implements ServletContextListener {
1859+
1860+
private ClassLoader contextClassLoader;
1861+
1862+
@Override
1863+
public void contextInitialized(ServletContextEvent sce) {
1864+
this.contextClassLoader = Thread.currentThread().getContextClassLoader();
1865+
}
1866+
1867+
}
1868+
1869+
static class ThreadContextClassLoaderCapturingFilter implements Filter {
1870+
1871+
private ClassLoader contextClassLoader;
1872+
1873+
@Override
1874+
public void init(FilterConfig filterConfig) throws ServletException {
1875+
this.contextClassLoader = Thread.currentThread().getContextClassLoader();
1876+
}
1877+
1878+
@Override
1879+
public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain)
1880+
throws IOException, ServletException {
1881+
chain.doFilter(request, response);
1882+
}
1883+
1884+
}
1885+
18251886
}

0 commit comments

Comments
 (0)