Don't reuse Testcontainers containers if reuse is globally disabled

Fixes gh-39609

Author: scottfrederick

spring-boot-project/spring-boot-testcontainers/src/main/java/org/springframework/boot/testcontainers/lifecycle/TestcontainersLifecycleBeanPostProcessor.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2023 the original author or authors.
+ * Copyright 2012-2024 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -25,6 +25,7 @@
 import org.testcontainers.containers.ContainerState;
 import org.testcontainers.containers.GenericContainer;
 import org.testcontainers.lifecycle.Startable;
+import org.testcontainers.utility.TestcontainersConfiguration;
 
 import org.springframework.beans.BeansException;
 import org.springframework.beans.factory.BeanCreationException;
@@ -49,6 +50,7 @@
  *
  * @author Phillip Webb
  * @author Stephane Nicoll
+ * @author Scott Frederick
  * @see TestcontainersLifecycleApplicationContextInitializer
  */
 @Order(Ordered.LOWEST_PRECEDENCE)
@@ -124,7 +126,8 @@ private boolean isDestroyedByFramework(String beanName) {
 	}
 
 	private boolean isReusedContainer(Object bean) {
-		return (bean instanceof GenericContainer<?> container) && container.isShouldBeReused();
+		return (bean instanceof GenericContainer<?> container) && container.isShouldBeReused()
+				&& TestcontainersConfiguration.getInstance().environmentSupportsReuse();
 	}
 
 }

spring-boot-project/spring-boot-testcontainers/src/test/java/org/springframework/boot/testcontainers/lifecycle/TestcontainersLifecycleApplicationContextInitializerTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2023 the original author or authors.
+ * Copyright 2012-2024 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -16,9 +16,11 @@
 
 package org.springframework.boot.testcontainers.lifecycle;
 
+import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.testcontainers.containers.GenericContainer;
 import org.testcontainers.lifecycle.Startable;
+import org.testcontainers.utility.TestcontainersConfiguration;
 
 import org.springframework.context.annotation.AnnotationConfigApplicationContext;
 import org.springframework.context.annotation.Bean;
@@ -38,9 +40,15 @@
  *
  * @author Stephane Nicoll
  * @author Phillip Webb
+ * @author Scott Frederick
  */
 class TestcontainersLifecycleApplicationContextInitializerTests {
 
+	@BeforeEach
+	void setUp() {
+		TestcontainersConfiguration.getInstance().updateUserConfig("testcontainers.reuse.enable", "false");
+	}
+
 	@Test
 	void whenStartableBeanInvokesStartOnRefresh() {
 		Startable container = mock(Startable.class);
@@ -62,7 +70,8 @@ void whenStartableBeanInvokesCloseOnShutdown() {
 	}
 
 	@Test
-	void whenReusableContainerBeanInvokesStartButNotClose() {
+	void whenReusableContainerAndReuseEnabledBeanInvokesStartButNotClose() {
+		TestcontainersConfiguration.getInstance().updateUserConfig("testcontainers.reuse.enable", "true");
 		GenericContainer<?> container = mock(GenericContainer.class);
 		given(container.isShouldBeReused()).willReturn(true);
 		AnnotationConfigApplicationContext applicationContext = createApplicationContext(container);
@@ -74,7 +83,20 @@ void whenReusableContainerBeanInvokesStartButNotClose() {
 	}
 
 	@Test
-	void whenReusableContainerBeanFromConfigurationInvokesStartButNotClose() {
+	void whenReusableContainerButReuseNotEnabledBeanInvokesStartAndClose() {
+		GenericContainer<?> container = mock(GenericContainer.class);
+		given(container.isShouldBeReused()).willReturn(true);
+		AnnotationConfigApplicationContext applicationContext = createApplicationContext(container);
+		then(container).shouldHaveNoInteractions();
+		applicationContext.refresh();
+		then(container).should().start();
+		applicationContext.close();
+		then(container).should(times(1)).close();
+	}
+
+	@Test
+	void whenReusableContainerAndReuseEnabledBeanFromConfigurationInvokesStartButNotClose() {
+		TestcontainersConfiguration.getInstance().updateUserConfig("testcontainers.reuse.enable", "true");
 		AnnotationConfigApplicationContext applicationContext = new AnnotationConfigApplicationContext();
 		new TestcontainersLifecycleApplicationContextInitializer().initialize(applicationContext);
 		applicationContext.register(ReusableContainerConfiguration.class);
@@ -85,6 +107,18 @@ void whenReusableContainerBeanFromConfigurationInvokesStartButNotClose() {
 		then(container).should(never()).close();
 	}
 
+	@Test
+	void whenReusableContainerButReuseNotEnabledBeanFromConfigurationInvokesStartAndClose() {
+		AnnotationConfigApplicationContext applicationContext = new AnnotationConfigApplicationContext();
+		new TestcontainersLifecycleApplicationContextInitializer().initialize(applicationContext);
+		applicationContext.register(ReusableContainerConfiguration.class);
+		applicationContext.refresh();
+		GenericContainer<?> container = applicationContext.getBean(GenericContainer.class);
+		then(container).should().start();
+		applicationContext.close();
+		then(container).should(times(1)).close();
+	}
+
 	@Test
 	void doesNotInitializeSameContextMoreThanOnce() {
 		AnnotationConfigApplicationContext applicationContext = new AnnotationConfigApplicationContext();