Fix warnings

Author: philwebb

spring-boot-autoconfigure/pom.xml

@@ -613,7 +613,6 @@
 		<dependency>
 			<groupId>org.springframework.kafka</groupId>
 			<artifactId>spring-kafka-test</artifactId>
-			<version>${spring-kafka.version}</version>
 			<scope>test</scope>
 			<exclusions>
 				<exclusion>

spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jdbc/DataSourceAutoConfiguration.java

@@ -103,6 +103,7 @@ protected static class EmbeddedDatabaseConfiguration {
 	@Import({ DataSourceConfiguration.Tomcat.class, DataSourceConfiguration.Hikari.class,
 			DataSourceConfiguration.Dbcp.class, DataSourceConfiguration.Dbcp2.class,
 			DataSourceConfiguration.Generic.class })
+	@SuppressWarnings("deprecation")
 	protected static class PooledDataSourceConfiguration {
 
 	}

spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jdbc/DataSourceConfiguration.java

@@ -42,6 +42,9 @@ protected <T> T createDataSource(DataSourceProperties properties,
 		return (T) properties.initializeDataSourceBuilder().type(type).build();
 	}
 
+	/**
+	 * Tomcat Pool DataSource configuration.
+	 */
 	@ConditionalOnClass(org.apache.tomcat.jdbc.pool.DataSource.class)
 	@ConditionalOnProperty(name = "spring.datasource.type", havingValue = "org.apache.tomcat.jdbc.pool.DataSource", matchIfMissing = true)
 	static class Tomcat extends DataSourceConfiguration {
@@ -64,6 +67,9 @@ public org.apache.tomcat.jdbc.pool.DataSource dataSource(
 
 	}
 
+	/**
+	 * Hikari DataSource configuration.
+	 */
 	@ConditionalOnClass(HikariDataSource.class)
 	@ConditionalOnProperty(name = "spring.datasource.type", havingValue = "com.zaxxer.hikari.HikariDataSource", matchIfMissing = true)
 	static class Hikari extends DataSourceConfiguration {
@@ -75,6 +81,10 @@ public HikariDataSource dataSource(DataSourceProperties properties) {
 		}
 	}
 
+	/**
+	 * DBCP DataSource configuration.
+	 * @deprecated as of Spring Boot 1.5 in favor of DBCP2
+	 */
 	@ConditionalOnClass(org.apache.commons.dbcp.BasicDataSource.class)
 	@ConditionalOnProperty(name = "spring.datasource.type", havingValue = "org.apache.commons.dbcp.BasicDataSource", matchIfMissing = true)
 	@Deprecated
@@ -97,6 +107,9 @@ public org.apache.commons.dbcp.BasicDataSource dataSource(
 		}
 	}
 
+	/**
+	 * DBCP DataSource configuration.
+	 */
 	@ConditionalOnClass(org.apache.commons.dbcp2.BasicDataSource.class)
 	@ConditionalOnProperty(name = "spring.datasource.type", havingValue = "org.apache.commons.dbcp2.BasicDataSource", matchIfMissing = true)
 	static class Dbcp2 extends DataSourceConfiguration {
@@ -110,6 +123,9 @@ public org.apache.commons.dbcp2.BasicDataSource dataSource(
 		}
 	}
 
+	/**
+	 * Generic DataSource configuration.
+	 */
 	@ConditionalOnMissingBean(DataSource.class)
 	@ConditionalOnProperty(name = "spring.datasource.type")
 	static class Generic {