Skip to content

Commit ec72d28

Browse files
committed
Merge pull request #17040 from wonwoo
* pr/17040: Polish "Replace anonymous class with lambdas" Replace anonymous class with lambdas Closes gh-17040
2 parents 0fcc561 + 114f9f9 commit ec72d28

File tree

2 files changed

+15
-50
lines changed

2 files changed

+15
-50
lines changed

spring-boot-project/spring-boot/src/test/java/org/springframework/boot/web/embedded/tomcat/TomcatServletWebServerFactoryTests.java

Lines changed: 12 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@
6868

6969
import org.springframework.boot.testsupport.rule.OutputCapture;
7070
import org.springframework.boot.web.server.WebServerException;
71-
import org.springframework.boot.web.servlet.ServletContextInitializer;
7271
import org.springframework.boot.web.servlet.server.AbstractServletWebServerFactory;
7372
import org.springframework.boot.web.servlet.server.AbstractServletWebServerFactoryTests;
7473
import org.springframework.core.io.ByteArrayResource;
@@ -538,25 +537,19 @@ public void nonExistentUploadDirectoryIsCreatedUponMultipartUpload()
538537
throws IOException, URISyntaxException {
539538
TomcatServletWebServerFactory factory = new TomcatServletWebServerFactory(0);
540539
AtomicReference<ServletContext> servletContextReference = new AtomicReference<>();
541-
factory.addInitializers(new ServletContextInitializer() {
542-
543-
@Override
544-
public void onStartup(ServletContext servletContext) throws ServletException {
545-
servletContextReference.set(servletContext);
546-
Dynamic servlet = servletContext.addServlet("upload", new HttpServlet() {
547-
548-
@Override
549-
protected void doPost(HttpServletRequest req,
550-
HttpServletResponse resp)
551-
throws ServletException, IOException {
552-
req.getParts();
553-
}
554-
555-
});
556-
servlet.addMapping("/upload");
557-
servlet.setMultipartConfig(new MultipartConfigElement((String) null));
558-
}
540+
factory.addInitializers((servletContext) -> {
541+
servletContextReference.set(servletContext);
542+
Dynamic servlet = servletContext.addServlet("upload", new HttpServlet() {
543+
544+
@Override
545+
protected void doPost(HttpServletRequest req, HttpServletResponse resp)
546+
throws ServletException, IOException {
547+
req.getParts();
548+
}
559549

550+
});
551+
servlet.addMapping("/upload");
552+
servlet.setMultipartConfig(new MultipartConfigElement((String) null));
560553
});
561554
this.webServer = factory.getWebServer();
562555
this.webServer.start();

spring-boot-project/spring-boot/src/test/java/org/springframework/boot/web/servlet/server/AbstractServletWebServerFactoryTests.java

Lines changed: 3 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import java.net.InetSocketAddress;
2626
import java.net.MalformedURLException;
2727
import java.net.ServerSocket;
28-
import java.net.Socket;
2928
import java.net.URI;
3029
import java.net.URISyntaxException;
3130
import java.net.URL;
@@ -75,8 +74,6 @@
7574
import org.apache.http.impl.client.HttpClientBuilder;
7675
import org.apache.http.impl.client.HttpClients;
7776
import org.apache.http.protocol.HttpContext;
78-
import org.apache.http.ssl.PrivateKeyDetails;
79-
import org.apache.http.ssl.PrivateKeyStrategy;
8077
import org.apache.http.ssl.SSLContextBuilder;
8178
import org.apache.http.ssl.TrustStrategy;
8279
import org.apache.jasper.EmbeddedServletOptions;
@@ -503,16 +500,7 @@ public void pkcs12KeyStoreAndTrustStore() throws Exception {
503500
new SSLContextBuilder()
504501
.loadTrustMaterial(null, new TrustSelfSignedStrategy())
505502
.loadKeyMaterial(keyStore, "secret".toCharArray(),
506-
new PrivateKeyStrategy() {
507-
508-
@Override
509-
public String chooseAlias(
510-
Map<String, PrivateKeyDetails> aliases,
511-
Socket socket) {
512-
return "spring-boot";
513-
}
514-
515-
})
503+
(aliases, socket) -> "spring-boot")
516504
.build());
517505
HttpClient httpClient = HttpClients.custom().setSSLSocketFactory(socketFactory)
518506
.build();
@@ -538,15 +526,7 @@ public void sslNeedsClientAuthenticationSucceedsWithClientCertificate()
538526
new SSLContextBuilder()
539527
.loadTrustMaterial(null, new TrustSelfSignedStrategy())
540528
.loadKeyMaterial(keyStore, "password".toCharArray(),
541-
new PrivateKeyStrategy() {
542-
543-
@Override
544-
public String chooseAlias(
545-
Map<String, PrivateKeyDetails> aliases,
546-
Socket socket) {
547-
return "spring-boot";
548-
}
549-
})
529+
(aliases, socket) -> "spring-boot")
550530
.build());
551531
HttpClient httpClient = HttpClients.custom().setSSLSocketFactory(socketFactory)
552532
.build();
@@ -639,15 +619,7 @@ public void sslWithCustomSslStoreProvider() throws Exception {
639619
new SSLContextBuilder()
640620
.loadTrustMaterial(null, new TrustSelfSignedStrategy())
641621
.loadKeyMaterial(keyStore, "password".toCharArray(),
642-
new PrivateKeyStrategy() {
643-
644-
@Override
645-
public String chooseAlias(
646-
Map<String, PrivateKeyDetails> aliases,
647-
Socket socket) {
648-
return "spring-boot";
649-
}
650-
})
622+
(aliases, socket) -> "spring-boot")
651623
.build());
652624
HttpClient httpClient = HttpClients.custom().setSSLSocketFactory(socketFactory)
653625
.build();

0 commit comments

Comments
 (0)