Skip to content

Commit e6dfd7c

Browse files
committed
Work around problems with GemFire 8.0’s dependencies
GemFire 8.0 depends on two different versions of xml-apis:xml-apis and org.eclipse.jdt.core.compiler:ecj. This commit adds dependency management for those two dependencies to address the dependency convergence errors reported by Maven’s enforcer plugin. GemFire 8.0 also depends on commons-logging and Spring Boot starters should use jcl-over-slf4j instead. This commit adds an exclusion for commons-logging GemFire 8.0 depends (optionally) on spring-data-gemfire and spring-data-gemfire depends on GemFire, i.e. there’s a dependency cycle between the two projects. This commit breaks this cycle by adding an exclusion for spring-data-gemfire to the dependency management for com.gemstone.gemfire:gemfire. This commit should be reverted once the problems with GemFire’s dependencies have been addressed. See gh-2884.
1 parent aa3a5ab commit e6dfd7c

File tree

2 files changed

+24
-0
lines changed
  • spring-boot-dependencies
  • spring-boot-starters/spring-boot-starter-data-gemfire

2 files changed

+24
-0
lines changed

spring-boot-dependencies/pom.xml

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@
6464
<ehcache.version>2.9.1</ehcache.version>
6565
<flyway.version>3.2.1</flyway.version>
6666
<freemarker.version>2.3.22</freemarker.version>
67+
<ecj.version>4.4.2</ecj.version>
6768
<elasticsearch.version>1.4.4</elasticsearch.version>
6869
<gemfire.version>8.0.0</gemfire.version>
6970
<glassfish-el.version>3.0.0</glassfish-el.version>
@@ -146,6 +147,7 @@
146147
<velocity.version>1.7</velocity.version>
147148
<velocity-tools.version>2.0</velocity-tools.version>
148149
<wsdl4j.version>1.6.3</wsdl4j.version>
150+
<xml-apis.version>1.3.04</xml-apis.version>
149151
</properties>
150152
<prerequisites>
151153
<maven>3.0.2</maven>
@@ -497,6 +499,12 @@
497499
<groupId>com.gemstone.gemfire</groupId>
498500
<artifactId>gemfire</artifactId>
499501
<version>${gemfire.version}</version>
502+
<exclusions>
503+
<exclusion>
504+
<groupId>org.springframework.data</groupId>
505+
<artifactId>spring-data-gemfire</artifactId>
506+
</exclusion>
507+
</exclusions>
500508
</dependency>
501509
<dependency>
502510
<groupId>com.github.mxab.thymeleaf.extras</groupId>
@@ -995,6 +1003,11 @@
9951003
<artifactId>crash.shell</artifactId>
9961004
<version>${crashub.version}</version>
9971005
</dependency>
1006+
<dependency>
1007+
<groupId>org.eclipse.jdt.core.compiler</groupId>
1008+
<artifactId>ecj</artifactId>
1009+
<version>${ecj.version}</version>
1010+
</dependency>
9981011
<dependency>
9991012
<groupId>org.eclipse.jetty</groupId>
10001013
<artifactId>jetty-annotations</artifactId>
@@ -1586,6 +1599,11 @@
15861599
<artifactId>wsdl4j</artifactId>
15871600
<version>${wsdl4j.version}</version>
15881601
</dependency>
1602+
<dependency>
1603+
<groupId>xml-apis</groupId>
1604+
<artifactId>xml-apis</artifactId>
1605+
<version>${xml-apis.version}</version>
1606+
</dependency>
15891607
</dependencies>
15901608
</dependencyManagement>
15911609
<build>

spring-boot-starters/spring-boot-starter-data-gemfire/pom.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,12 @@
2525
<dependency>
2626
<groupId>com.gemstone.gemfire</groupId>
2727
<artifactId>gemfire</artifactId>
28+
<exclusions>
29+
<exclusion>
30+
<groupId>commons-logging</groupId>
31+
<artifactId>commons-logging</artifactId>
32+
</exclusion>
33+
</exclusions>
2834
</dependency>
2935
<dependency>
3036
<groupId>org.springframework.data</groupId>

0 commit comments

Comments
 (0)