Skip to content

Commit da49128

Browse files
committed
Merge pull request #13487 from izeye:caches-endpoint
* pr/13487: Polish CachesEndpoint
2 parents 7ed06f3 + 403f892 commit da49128

File tree

1 file changed

+7
-10
lines changed
  • spring-boot-project/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/cache

1 file changed

+7
-10
lines changed

spring-boot-project/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/cache/CachesEndpoint.java

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
package org.springframework.boot.actuate.cache;
1818

19-
import java.util.ArrayList;
2019
import java.util.LinkedHashMap;
2120
import java.util.List;
2221
import java.util.Map;
@@ -112,21 +111,19 @@ public boolean clearCache(@Selector String cache, @Nullable String cacheManager)
112111

113112
private List<CacheEntry> getCacheEntries(Predicate<String> cacheNamePredicate,
114113
Predicate<String> cacheManagerNamePredicate) {
115-
List<CacheEntry> entries = new ArrayList<>();
116-
this.cacheManagers.keySet().stream().filter(cacheManagerNamePredicate)
117-
.forEach((cacheManagerName) -> entries
118-
.addAll(getCacheEntries(cacheManagerName, cacheNamePredicate)));
119-
return entries;
114+
return this.cacheManagers.keySet().stream().filter(cacheManagerNamePredicate)
115+
.flatMap((cacheManagerName) -> getCacheEntries(cacheManagerName,
116+
cacheNamePredicate).stream())
117+
.collect(Collectors.toList());
120118
}
121119

122120
private List<CacheEntry> getCacheEntries(String cacheManagerName,
123121
Predicate<String> cacheNamePredicate) {
124122
CacheManager cacheManager = this.cacheManagers.get(cacheManagerName);
125-
List<CacheEntry> entries = new ArrayList<>();
126-
cacheManager.getCacheNames().stream().filter(cacheNamePredicate)
123+
return cacheManager.getCacheNames().stream().filter(cacheNamePredicate)
127124
.map(cacheManager::getCache).filter(Objects::nonNull)
128-
.forEach((cache) -> entries.add(new CacheEntry(cache, cacheManagerName)));
129-
return entries;
125+
.map((cache) -> new CacheEntry(cache, cacheManagerName))
126+
.collect(Collectors.toList());
130127
}
131128

132129
private CacheEntry extractUniqueCacheEntry(String cache, List<CacheEntry> entries) {

0 commit comments

Comments
 (0)