Polish "Add socketKeepAlive configuration property for Elasticsearch"

See gh-32051

Author: snicoll

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/elasticsearch/ElasticsearchProperties.java

@@ -58,14 +58,14 @@ public class ElasticsearchProperties {
 	private Duration socketTimeout = Duration.ofSeconds(30);
 
 	/**
-	 * Prefix added to the path of every request sent to Elasticsearch.
+	 * Whether to enable socket keep alive between client and Elasticsearch.
 	 */
-	private String pathPrefix;
+	private boolean socketKeepAlive = false;
 
 	/**
-	 * Whether to enable socket keep alive between client and Elasticsearch.
+	 * Prefix added to the path of every request sent to Elasticsearch.
 	 */
-	private boolean socketKeepAlive = false;
+	private String pathPrefix;
 
 	private final Restclient restclient = new Restclient();
 
@@ -109,14 +109,6 @@ public void setSocketTimeout(Duration socketTimeout) {
 		this.socketTimeout = socketTimeout;
 	}
 
-	public String getPathPrefix() {
-		return this.pathPrefix;
-	}
-
-	public void setPathPrefix(String pathPrefix) {
-		this.pathPrefix = pathPrefix;
-	}
-
 	public boolean isSocketKeepAlive() {
 		return this.socketKeepAlive;
 	}
@@ -125,6 +117,14 @@ public void setSocketKeepAlive(boolean socketKeepAlive) {
 		this.socketKeepAlive = socketKeepAlive;
 	}
 
+	public String getPathPrefix() {
+		return this.pathPrefix;
+	}
+
+	public void setPathPrefix(String pathPrefix) {
+		this.pathPrefix = pathPrefix;
+	}
+
 	public Restclient getRestclient() {
 		return this.restclient;
 	}

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/elasticsearch/ElasticsearchRestClientConfigurations.java

@@ -156,8 +156,8 @@ public void customize(RestClientBuilder builder) {
 		@Override
 		public void customize(HttpAsyncClientBuilder builder) {
 			builder.setDefaultCredentialsProvider(new PropertiesCredentialsProvider(this.properties));
-			map.from(this.properties::isSocketKeepAlive).whenTrue()
-					.to(keepalive -> builder.setDefaultIOReactorConfig(IOReactorConfig.custom().setSoKeepAlive(keepalive).build()));
+			map.from(this.properties::isSocketKeepAlive).to((keepAlive) -> builder
+					.setDefaultIOReactorConfig(IOReactorConfig.custom().setSoKeepAlive(keepAlive).build()));
 		}
 
 		@Override

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/elasticsearch/ElasticsearchRestClientAutoConfigurationTests.java

@@ -184,20 +184,19 @@ void configureWithCustomPathPrefix() {
 	}
 
 	@Test
-	void socketKeepAliveDefaults() {
+	void configureWithNoSocketKeepAliveApplyDefault() {
 		RestClient client = RestClient.builder(new HttpHost("localhost", 9201, "http")).build();
 		assertThat(client.getHttpClient()).extracting("connmgr.ioReactor.config.soKeepAlive").isEqualTo(Boolean.FALSE);
 	}
 
 	@Test
 	void configureWithCustomSocketKeepAlive() {
-		this.contextRunner.withPropertyValues("spring.elasticsearch.socket-keep-alive=true").run(
-				context -> {
-					assertThat(context).hasSingleBean(RestClient.class);
-					RestClient client = context.getBean(RestClient.class);
-					assertThat(client.getHttpClient()).extracting("connmgr.ioReactor.config.soKeepAlive").isEqualTo(Boolean.TRUE);
-				}
-		);
+		this.contextRunner.withPropertyValues("spring.elasticsearch.socket-keep-alive=true").run((context) -> {
+			assertThat(context).hasSingleBean(RestClient.class);
+			RestClient client = context.getBean(RestClient.class);
+			assertThat(client.getHttpClient()).extracting("connmgr.ioReactor.config.soKeepAlive")
+					.isEqualTo(Boolean.TRUE);
+		});
 	}
 
 	@Test