Calculate hashCode only once in ConfigurationPropertyName

See gh-21394

Author: dreis2211

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/context/properties/source/ConfigurationPropertyName.java

@@ -444,6 +444,7 @@ public int hashCode() {
 				}
 				hashCode = 31 * hashCode + elementHashCode;
 			}
+			this.hashCode = hashCode;
 		}
 		return hashCode;
 	}

spring-boot-project/spring-boot/src/test/java/org/springframework/boot/context/properties/source/ConfigurationPropertyNameTests.java

@@ -24,6 +24,7 @@
 import org.junit.jupiter.api.Test;
 
 import org.springframework.boot.context.properties.source.ConfigurationPropertyName.Form;
+import org.springframework.test.util.ReflectionTestUtils;
 
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
@@ -619,4 +620,12 @@ void isValidWhenNotValidShouldReturnFalse() {
 		assertThat(ConfigurationPropertyName.isValid("foo!bar")).isFalse();
 	}
 
+	@Test
+	void hashCodeIsOnlyCalculatedOnce() {
+		ConfigurationPropertyName name = ConfigurationPropertyName.of("hash.code");
+		int hashCode = name.hashCode();
+		int hashCodeField = (int) ReflectionTestUtils.getField(name, "hashCode");
+		assertThat(hashCodeField).isEqualTo(hashCode);
+	}
+
 }