Skip to content

Commit c2459fc

Browse files
committed
Raise the minimum version of Gradle to 4.0
Closes gh-9516
1 parent 32a4067 commit c2459fc

File tree

11 files changed

+19
-27
lines changed

11 files changed

+19
-27
lines changed

spring-boot-docs/src/main/asciidoc/build-tool-plugins.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ Advanced configuration options and examples are available in the
166166
== Spring Boot Gradle plugin
167167
The Spring Boot Gradle Plugin provides Spring Boot support in Gradle, allowing you to
168168
package executable jar or war archives, run Spring Boot applications and use the
169-
dependency management provided by `spring-boot-dependencies`. It requires Gradle 3.4 or
169+
dependency management provided by `spring-boot-dependencies`. It requires Gradle 4.0 or
170170
later. Please refer to the plugin's documentation to learn more:
171171

172172
* Reference ({spring-boot-gradle-plugin}/reference/html[HTML] and

spring-boot-docs/src/main/asciidoc/getting-started.adoc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ diverge from the defaults.
3838
== System Requirements
3939
Spring Boot {spring-boot-version} requires http://www.java.com[Java 8] and Spring
4040
Framework {spring-version} or above. Explicit build support is provided for Maven
41-
(3.2+), and Gradle 3 (3.4 or later).
41+
(3.2+), and Gradle 4.
4242

4343

4444
[[getting-started-system-requirements-servlet-containers]]
@@ -185,8 +185,8 @@ scope.
185185

186186
[[getting-started-gradle-installation]]
187187
==== Gradle installation
188-
Spring Boot is compatible with Gradle 3 (3.4 or later). If you don't already have Gradle
189-
installed you can follow the instructions at http://www.gradle.org/.
188+
Spring Boot is compatible with Gradle 4. If you don't already have Gradle installed you
189+
can follow the instructions at http://www.gradle.org/.
190190

191191
Spring Boot dependencies can be declared using the `org.springframework.boot` `group`.
192192
Typically your project will declare dependencies to one or more

spring-boot-docs/src/main/asciidoc/index.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ Phillip Webb; Dave Syer; Josh Long; Stéphane Nicoll; Rob Winch; Andy Wilkinson;
5151
:propdeps-plugin: https://github.com/spring-projects/gradle-plugins/tree/master/propdeps-plugin
5252
:ant-manual: http://ant.apache.org/manual
5353
:code-examples: ../java/org/springframework/boot
54-
:gradle-user-guide: https://docs.gradle.org/3.4.1/userguide
54+
:gradle-user-guide: https://docs.gradle.org/4.0.2/userguide
5555
:hibernate-documentation: http://docs.jboss.org/hibernate/orm/5.2/userguide/html_single/Hibernate_User_Guide.html
5656
:jetty-documentation: https://www.eclipse.org/jetty/documentation/9.4.x
5757
:tomcat-documentation: https://tomcat.apache.org/tomcat-8.5-doc

spring-boot-tools/spring-boot-gradle-plugin/build.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
plugins {
22
id 'java'
33
id 'eclipse'
4-
id 'org.sonarqube' version '2.2.1'
54
}
65

76
repositories {
Binary file not shown.
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
#Thu Mar 16 20:08:41 GMT 2017
1+
#Thu Jul 27 14:32:22 BST 2017
22
distributionBase=GRADLE_USER_HOME
33
distributionPath=wrapper/dists
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists
6-
distributionUrl=https\://services.gradle.org/distributions/gradle-3.4-bin.zip
6+
distributionUrl=https\://services.gradle.org/distributions/gradle-4.0.2-bin.zip

spring-boot-tools/spring-boot-gradle-plugin/src/main/asciidoc/index.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ Andy Wilkinson
3636
The Spring Boot Gradle Plugin provides Spring Boot support in https://gradle.org[Gradle],
3737
allowing you to package executable jar or war archives, run Spring Boot applications, and
3838
use the dependency management provided by `spring-boot-dependencies`. Spring Boot's
39-
Gradle plugin requires Gradle 3.4 or later.
39+
Gradle plugin requires Gradle 4.0 or later.
4040

4141
In addition to this user guide, {api-documentation}[API documentation] is also available.
4242

spring-boot-tools/spring-boot-gradle-plugin/src/main/java/org/springframework/boot/gradle/plugin/SpringBootPlugin.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,8 @@ public void apply(Project project) {
6868
}
6969

7070
private void verifyGradleVersion() {
71-
if (GradleVersion.current().compareTo(GradleVersion.version("3.4")) < 0) {
72-
throw new GradleException("Spring Boot plugin requires Gradle 3.4 or later."
71+
if (GradleVersion.current().compareTo(GradleVersion.version("4.0")) < 0) {
72+
throw new GradleException("Spring Boot plugin requires Gradle 4.0 or later."
7373
+ " The current version is " + GradleVersion.current());
7474
}
7575
}

spring-boot-tools/spring-boot-gradle-plugin/src/test/java/org/springframework/boot/gradle/junit/GradleCompatibilitySuite.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@
3838
*/
3939
public final class GradleCompatibilitySuite extends Suite {
4040

41-
private static final List<String> GRADLE_VERSIONS = Arrays.asList("default", "3.4.1",
42-
"3.5", "3.5.1", "4.0", "4.0.1", "4.1-rc-1");
41+
private static final List<String> GRADLE_VERSIONS = Arrays.asList("default",
42+
"4.1-rc-1");
4343

4444
public GradleCompatibilitySuite(Class<?> clazz) throws InitializationError {
4545
super(clazz, createRunners(clazz));

spring-boot-tools/spring-boot-gradle-plugin/src/test/java/org/springframework/boot/gradle/plugin/SpringBootPluginIntegrationTests.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,19 +36,19 @@ public class SpringBootPluginIntegrationTests {
3636

3737
@Test
3838
public void failFastWithVersionOfGradleLowerThanRequired() {
39-
BuildResult result = this.gradleBuild.gradleVersion("3.3").buildAndFail();
40-
assertThat(result.getOutput()).contains("Spring Boot plugin requires Gradle 3.4"
41-
+ " or later. The current version is Gradle 3.3");
39+
BuildResult result = this.gradleBuild.gradleVersion("3.5.1").buildAndFail();
40+
assertThat(result.getOutput()).contains("Spring Boot plugin requires Gradle 4.0"
41+
+ " or later. The current version is Gradle 3.5.1");
4242
}
4343

4444
@Test
4545
public void succeedWithVersionOfGradleHigherThanRequired() {
46-
this.gradleBuild.gradleVersion("3.5").build();
46+
this.gradleBuild.gradleVersion("4.0.1").build();
4747
}
4848

4949
@Test
5050
public void succeedWithVersionOfGradleMatchingWhatIsRequired() {
51-
this.gradleBuild.gradleVersion("3.4").build();
51+
this.gradleBuild.gradleVersion("4.0").build();
5252
}
5353

5454
}

spring-boot-tools/spring-boot-gradle-plugin/src/test/java/org/springframework/boot/gradle/tasks/run/BootRunIntegrationTests.java

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public void basicExecution() throws IOException {
5151
new File(this.gradleBuild.getProjectDir(), "src/main/resources").mkdirs();
5252
BuildResult result = this.gradleBuild.build("bootRun");
5353
assertThat(result.task(":bootRun").getOutcome()).isEqualTo(TaskOutcome.SUCCESS);
54-
assertThat(result.getOutput()).contains("1. " + urlOf(mainJavaOutput()));
54+
assertThat(result.getOutput()).contains("1. " + urlOf("build/classes/java/main"));
5555
assertThat(result.getOutput()).contains("2. " + urlOf("build/resources/main"));
5656
assertThat(result.getOutput()).doesNotContain(urlOf("src/main/resources"));
5757
}
@@ -65,7 +65,7 @@ public void sourceResourcesCanBeUsed() throws IOException {
6565
BuildResult result = this.gradleBuild.build("bootRun");
6666
assertThat(result.task(":bootRun").getOutcome()).isEqualTo(TaskOutcome.SUCCESS);
6767
assertThat(result.getOutput()).contains("1. " + urlOf("src/main/resources"));
68-
assertThat(result.getOutput()).contains("2. " + urlOf(mainJavaOutput()));
68+
assertThat(result.getOutput()).contains("2. " + urlOf("build/classes/java/main"));
6969
assertThat(result.getOutput()).doesNotContain(urlOf("build/resources/main"));
7070
}
7171

@@ -87,13 +87,6 @@ public void applicationPluginJvmArgumentsAreUsed() throws IOException {
8787
.contains("JVM arguments = [-Dcom.foo=bar, -Dcom.bar=baz]");
8888
}
8989

90-
private String mainJavaOutput() {
91-
String gradleVersion = this.gradleBuild.getGradleVersion();
92-
return "build/classes/"
93-
+ (gradleVersion != null && gradleVersion.startsWith("4.") ? "java/" : "")
94-
+ "main";
95-
}
96-
9790
private String urlOf(String path) throws IOException {
9891
return new File(this.gradleBuild.getProjectDir().getCanonicalFile(), path).toURI()
9992
.toURL().toString();

0 commit comments

Comments
 (0)