Skip to content

Commit b7ac1e6

Browse files
committed
Rename derivefrom to align with DataSourceBuilder
Rename the `derivefrom` method in `ConnectionFactoryBuilder` to `derivedFrom` to align with `DataSourceBuilder`. Fixes gh-26810
1 parent f8c3e0e commit b7ac1e6

File tree

3 files changed

+21
-5
lines changed

3 files changed

+21
-5
lines changed

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/sql/init/R2dbcInitializationConfiguration.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,8 @@ R2dbcScriptDatabaseInitializer r2dbcScriptDatabaseInitializer(ConnectionFactory
5050
private static ConnectionFactory determineConnectionFactory(ConnectionFactory connectionFactory, String username,
5151
String password) {
5252
if (StringUtils.hasText(username) && StringUtils.hasText(password)) {
53-
return ConnectionFactoryBuilder.derivefrom(connectionFactory).username(username).password(password).build();
53+
return ConnectionFactoryBuilder.derivedFrom(connectionFactory).username(username).password(password)
54+
.build();
5455
}
5556
return connectionFactory;
5657
}

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/r2dbc/ConnectionFactoryBuilder.java

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,23 @@ public static ConnectionFactoryBuilder withOptions(Builder options) {
9292
* @param connectionFactory the connection factory whose options are to be used to
9393
* initialize the builder
9494
* @return a new builder initialized with the options from the connection factory
95+
* @deprecated since 2.5.0 for removal in 2.7.0 in favor of
96+
* {@link #derivedFrom(ConnectionFactory)}
9597
*/
98+
@Deprecated
9699
public static ConnectionFactoryBuilder derivefrom(ConnectionFactory connectionFactory) {
100+
return derivedFrom(connectionFactory);
101+
}
102+
103+
/**
104+
* Initialize a new {@link ConnectionFactoryBuilder} derived from the options of the
105+
* specified {@code connectionFactory}.
106+
* @param connectionFactory the connection factory whose options are to be used to
107+
* initialize the builder
108+
* @return a new builder initialized with the options from the connection factory
109+
* @since 2.5.1
110+
*/
111+
public static ConnectionFactoryBuilder derivedFrom(ConnectionFactory connectionFactory) {
97112
ConnectionFactoryOptions options = extractOptionsIfPossible(connectionFactory);
98113
if (options == null) {
99114
throw new IllegalArgumentException(

spring-boot-project/spring-boot/src/test/java/org/springframework/boot/r2dbc/ConnectionFactoryBuilderTests.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -141,8 +141,8 @@ void buildWhenDerivedWithNewDatabaseReturnsNewConnectionFactory() {
141141
.withUrl(EmbeddedDatabaseConnection.H2.getUrl(intialDatabaseName)).build();
142142
ConnectionFactoryOptions initialOptions = ((OptionsCapableConnectionFactory) connectionFactory).getOptions();
143143
String derivedDatabaseName = UUID.randomUUID().toString();
144-
ConnectionFactory derived = ConnectionFactoryBuilder.derivefrom(connectionFactory).database(derivedDatabaseName)
145-
.build();
144+
ConnectionFactory derived = ConnectionFactoryBuilder.derivedFrom(connectionFactory)
145+
.database(derivedDatabaseName).build();
146146
ConnectionFactoryOptions derivedOptions = ((OptionsCapableConnectionFactory) derived).getOptions();
147147
assertThat(derivedOptions.getRequiredValue(ConnectionFactoryOptions.DATABASE)).isEqualTo(derivedDatabaseName);
148148
assertMatchingOptions(derivedOptions, initialOptions, ConnectionFactoryOptions.CONNECT_TIMEOUT,
@@ -156,7 +156,7 @@ void buildWhenDerivedWithNewCredentialsReturnsNewConnectionFactory() {
156156
ConnectionFactory connectionFactory = ConnectionFactoryBuilder
157157
.withUrl(EmbeddedDatabaseConnection.H2.getUrl(UUID.randomUUID().toString())).build();
158158
ConnectionFactoryOptions initialOptions = ((OptionsCapableConnectionFactory) connectionFactory).getOptions();
159-
ConnectionFactory derived = ConnectionFactoryBuilder.derivefrom(connectionFactory).username("admin")
159+
ConnectionFactory derived = ConnectionFactoryBuilder.derivedFrom(connectionFactory).username("admin")
160160
.password("secret").build();
161161
ConnectionFactoryOptions derivedOptions = ((OptionsCapableConnectionFactory) derived).getOptions();
162162
assertThat(derivedOptions.getRequiredValue(ConnectionFactoryOptions.USER)).isEqualTo("admin");
@@ -173,7 +173,7 @@ void buildWhenDerivedFromPoolReturnsNewNonPooledConnectionFactory() {
173173
ConnectionFactoryOptions initialOptions = ((OptionsCapableConnectionFactory) connectionFactory).getOptions();
174174
ConnectionPoolConfiguration poolConfiguration = ConnectionPoolConfiguration.builder(connectionFactory).build();
175175
ConnectionPool pool = new ConnectionPool(poolConfiguration);
176-
ConnectionFactory derived = ConnectionFactoryBuilder.derivefrom(pool).username("admin").password("secret")
176+
ConnectionFactory derived = ConnectionFactoryBuilder.derivedFrom(pool).username("admin").password("secret")
177177
.build();
178178
assertThat(derived).isNotInstanceOf(ConnectionPool.class).isInstanceOf(OptionsCapableConnectionFactory.class);
179179
ConnectionFactoryOptions derivedOptions = ((OptionsCapableConnectionFactory) derived).getOptions();

0 commit comments

Comments
 (0)