Skip to content

Commit a67594e

Browse files
wilkinsonaphilwebb
authored andcommitted
Remove remaining usages of MetricsRun
1 parent 19be200 commit a67594e

File tree

3 files changed

+10
-115
lines changed

3 files changed

+10
-115
lines changed

spring-boot-project/spring-boot-actuator-autoconfigure-all/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/test/MetricsRun.java

Lines changed: 0 additions & 107 deletions
This file was deleted.

spring-boot-project/spring-boot-actuator-autoconfigure-all/src/test/java/org/springframework/boot/actuate/autoconfigure/observability/ObservabilityAutoConfigurationTests.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import io.micrometer.core.instrument.MeterRegistry;
2323
import io.micrometer.core.instrument.observation.DefaultMeterObservationHandler;
2424
import io.micrometer.core.instrument.observation.MeterObservationHandler;
25+
import io.micrometer.core.instrument.simple.SimpleMeterRegistry;
2526
import io.micrometer.observation.Observation;
2627
import io.micrometer.observation.Observation.Context;
2728
import io.micrometer.observation.ObservationHandler;
@@ -35,7 +36,6 @@
3536
import org.junit.jupiter.api.Test;
3637
import org.mockito.Answers;
3738

38-
import org.springframework.boot.actuate.autoconfigure.metrics.test.MetricsRun;
3939
import org.springframework.boot.autoconfigure.AutoConfigurations;
4040
import org.springframework.boot.observation.autoconfigure.ObservationAutoConfiguration;
4141
import org.springframework.boot.observation.autoconfigure.ObservationHandlerGrouping;
@@ -59,14 +59,15 @@
5959
*/
6060
class ObservabilityAutoConfigurationTests {
6161

62-
private final ApplicationContextRunner contextRunner = new ApplicationContextRunner().with(MetricsRun.simple())
62+
private final ApplicationContextRunner contextRunner = new ApplicationContextRunner()
63+
.withBean(SimpleMeterRegistry.class)
6364
.withPropertyValues("management.observations.annotations.enabled=true")
6465
.withClassLoader(new FilteredClassLoader("io.micrometer.tracing"))
6566
.withConfiguration(
6667
AutoConfigurations.of(ObservationAutoConfiguration.class, ObservabilityAutoConfiguration.class));
6768

6869
private final ApplicationContextRunner tracingContextRunner = new ApplicationContextRunner()
69-
.with(MetricsRun.simple())
70+
.withBean(SimpleMeterRegistry.class)
7071
.withPropertyValues("management.observations.annotations.enabled=true")
7172
.withUserConfiguration(TracerConfiguration.class)
7273
.withConfiguration(
@@ -114,7 +115,7 @@ void supplyMeterHandlerAndGroupingWhenMicrometerCoreAndTracingAreOnClassPath() {
114115

115116
@Test
116117
void supplyMeterHandlerAndGroupingWhenMicrometerCoreAndTracingAreOnClassPathButThereIsNoTracer() {
117-
new ApplicationContextRunner().with(MetricsRun.simple())
118+
new ApplicationContextRunner().withBean(SimpleMeterRegistry.class)
118119
.withPropertyValues("management.observations.annotations.enabled=true")
119120
.withConfiguration(
120121
AutoConfigurations.of(ObservationAutoConfiguration.class, ObservabilityAutoConfiguration.class))

spring-boot-project/spring-boot-actuator-autoconfigure-all/src/test/java/org/springframework/boot/actuate/autoconfigure/tracing/prometheus/PrometheusExemplarsAutoConfigurationTests.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,10 @@
3131
import io.prometheus.metrics.tracer.common.SpanContext;
3232
import org.junit.jupiter.api.Test;
3333

34-
import org.springframework.boot.actuate.autoconfigure.metrics.test.MetricsRun;
3534
import org.springframework.boot.actuate.autoconfigure.tracing.BraveAutoConfiguration;
3635
import org.springframework.boot.actuate.autoconfigure.tracing.MicrometerTracingAutoConfiguration;
3736
import org.springframework.boot.autoconfigure.AutoConfigurations;
37+
import org.springframework.boot.metrics.autoconfigure.MetricsAutoConfiguration;
3838
import org.springframework.boot.metrics.autoconfigure.export.prometheus.PrometheusMetricsExportAutoConfiguration;
3939
import org.springframework.boot.observation.autoconfigure.ObservationAutoConfiguration;
4040
import org.springframework.boot.test.context.FilteredClassLoader;
@@ -61,10 +61,11 @@ class PrometheusExemplarsAutoConfigurationTests {
6161

6262
private final ApplicationContextRunner contextRunner = new ApplicationContextRunner()
6363
.withPropertyValues("management.tracing.sampling.probability=1.0",
64-
"management.metrics.distribution.percentiles-histogram.all=true")
65-
.with(MetricsRun.limitedTo(PrometheusMetricsExportAutoConfiguration.class))
64+
"management.metrics.distribution.percentiles-histogram.all=true",
65+
"management.metrics.use-global-registry=false")
6666
.withConfiguration(
67-
AutoConfigurations.of(PrometheusExemplarsAutoConfiguration.class, ObservationAutoConfiguration.class,
67+
AutoConfigurations.of(MetricsAutoConfiguration.class, PrometheusMetricsExportAutoConfiguration.class,
68+
PrometheusExemplarsAutoConfiguration.class, ObservationAutoConfiguration.class,
6869
BraveAutoConfiguration.class, MicrometerTracingAutoConfiguration.class));
6970

7071
@Test

0 commit comments

Comments
 (0)