Polish "Use ClassLoader with ArchitectureCheck"

See gh-45202

Author: wilkinsona

Diff for: buildSrc/src/main/java/org/springframework/boot/build/architecture/ArchitectureCheck.java

@@ -125,7 +125,7 @@ private void withCompileClasspath(Callable<?> callable) throws Exception {
 	}
 
 	private void writeViolationReport(List<EvaluationResult> violations, File outputFile) throws IOException {
-		Files.createDirectories(outputFile.getParentFile().toPath());
+		outputFile.getParentFile().mkdirs();
 		StringBuilder report = new StringBuilder();
 		for (EvaluationResult violation : violations) {
 			report.append(violation.getFailureReport());

Diff for: buildSrc/src/test/java/org/springframework/boot/build/architecture/ArchitectureCheckTests.java

@@ -231,7 +231,6 @@ private void runGradleWithCompiledClasses(String path, Consumer<GradleRunner> ca
 	private void runGradle(Consumer<GradleRunner> callback) {
 		callback.accept(GradleRunner.create()
 			.withProjectDir(this.projectDir.toFile())
-			// .withArguments("checkArchitectureMain", "-Dorg.gradle.debug=true")
 			.withArguments("checkArchitectureMain")
 			.withPluginClasspath());
 	}