Skip to content

Commit 5cb23ae

Browse files
committed
Only disable test tasks when a project isn't compatible with toolchain
Disabling compilation means that any downstream project will break. For example, disabling our Gradle plugin's compileJava task means that the launch script test app fails to build as it uses our Gradle plugin and its classes are missing. See gh-gh-32280
1 parent 4523f01 commit 5cb23ae

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

buildSrc/src/main/java/org/springframework/boot/build/toolchain/ToolchainPlugin.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@
2323
import org.gradle.api.Plugin;
2424
import org.gradle.api.Project;
2525
import org.gradle.api.plugins.JavaPluginExtension;
26-
import org.gradle.api.tasks.compile.JavaCompile;
27-
import org.gradle.api.tasks.javadoc.Javadoc;
2826
import org.gradle.api.tasks.testing.Test;
2927
import org.gradle.jvm.toolchain.JavaLanguageVersion;
3028
import org.gradle.jvm.toolchain.JavaToolchainSpec;
@@ -67,8 +65,6 @@ private boolean isJavaVersionSupported(ToolchainExtension toolchain, JavaLanguag
6765
}
6866

6967
private void disableToolchainTasks(Project project) {
70-
project.getTasks().withType(JavaCompile.class, (task) -> task.setEnabled(false));
71-
project.getTasks().withType(Javadoc.class, (task) -> task.setEnabled(false));
7268
project.getTasks().withType(Test.class, (task) -> task.setEnabled(false));
7369
}
7470

0 commit comments

Comments
 (0)