Skip to content

Commit 5650a54

Browse files
committed
Merge branch '3.2.x'
Closes gh-39080
2 parents d610955 + 47564cc commit 5650a54

File tree

2 files changed

+18
-1
lines changed

2 files changed

+18
-1
lines changed

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/embedded/jetty/JettyServletWebServerFactory.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,7 @@
116116
* @author Venil Noronha
117117
* @author Henri Kerola
118118
* @author Moritz Halbritter
119+
* @author Onur Kagan Ozcan
119120
* @since 2.0.0
120121
* @see #setPort(int)
121122
* @see #setConfigurations(Collection)
@@ -183,7 +184,7 @@ public WebServer getWebServer(ServletContextInitializer... initializers) {
183184
server.setHandler(addHandlerWrappers(context));
184185
this.logger.info("Server initialized with port: " + port);
185186
if (this.maxConnections > -1) {
186-
server.addBean(new ConnectionLimit(this.maxConnections, server));
187+
server.addBean(new ConnectionLimit(this.maxConnections, server.getConnectors()));
187188
}
188189
if (Ssl.isEnabled(getSsl())) {
189190
customizeSsl(server, address);

spring-boot-project/spring-boot/src/test/java/org/springframework/boot/web/embedded/jetty/JettyServletWebServerFactoryTests.java

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,13 +39,15 @@
3939
import org.apache.hc.core5.http.Header;
4040
import org.apache.hc.core5.http.HttpResponse;
4141
import org.apache.jasper.servlet.JspServlet;
42+
import org.assertj.core.api.InstanceOfAssertFactories;
4243
import org.awaitility.Awaitility;
4344
import org.eclipse.jetty.ee10.servlet.ErrorPageErrorHandler;
4445
import org.eclipse.jetty.ee10.servlet.ServletHolder;
4546
import org.eclipse.jetty.ee10.webapp.AbstractConfiguration;
4647
import org.eclipse.jetty.ee10.webapp.ClassMatcher;
4748
import org.eclipse.jetty.ee10.webapp.Configuration;
4849
import org.eclipse.jetty.ee10.webapp.WebAppContext;
50+
import org.eclipse.jetty.server.AbstractConnector;
4951
import org.eclipse.jetty.server.ConnectionLimit;
5052
import org.eclipse.jetty.server.Connector;
5153
import org.eclipse.jetty.server.Handler;
@@ -85,6 +87,7 @@
8587
* @author Andy Wilkinson
8688
* @author Henri Kerola
8789
* @author Moritz Halbritter
90+
* @author Onur Kagan Ozcan
8891
*/
8992
class JettyServletWebServerFactoryTests extends AbstractServletWebServerFactoryTests {
9093

@@ -541,6 +544,19 @@ void shouldApplyMaxConnections() {
541544
assertThat(connectionLimit.getMaxConnections()).isOne();
542545
}
543546

547+
@Test
548+
void shouldApplyingMaxConnectionUseConnector() throws Exception {
549+
JettyServletWebServerFactory factory = getFactory();
550+
factory.setMaxConnections(1);
551+
this.webServer = factory.getWebServer();
552+
Server server = ((JettyWebServer) this.webServer).getServer();
553+
assertThat(server.getConnectors()).isEmpty();
554+
ConnectionLimit connectionLimit = server.getBean(ConnectionLimit.class);
555+
assertThat(connectionLimit).extracting("_connectors")
556+
.asInstanceOf(InstanceOfAssertFactories.list(AbstractConnector.class))
557+
.hasSize(1);
558+
}
559+
544560
@Override
545561
protected String startedLogMessage() {
546562
return ((JettyWebServer) this.webServer).getStartedLogMessage();

0 commit comments

Comments
 (0)