Skip to content

Commit 447ffb5

Browse files
committed
Merge pull request #40611 from snicoll
* pr/40611: Polish "Avoid using OkHttp3ClientHttpRequestFactory in test" Avoid using OkHttp3ClientHttpRequestFactory in test Closes gh-40611
2 parents 3b7d477 + 1534bc8 commit 447ffb5

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

spring-boot-project/spring-boot-test/src/test/java/org/springframework/boot/test/web/client/TestRestTemplateTests.java

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2012-2023 the original author or authors.
2+
* Copyright 2012-2024 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -38,7 +38,6 @@
3838
import org.springframework.http.client.ClientHttpRequest;
3939
import org.springframework.http.client.ClientHttpRequestFactory;
4040
import org.springframework.http.client.HttpComponentsClientHttpRequestFactory;
41-
import org.springframework.http.client.OkHttp3ClientHttpRequestFactory;
4241
import org.springframework.http.client.SimpleClientHttpRequestFactory;
4342
import org.springframework.mock.env.MockEnvironment;
4443
import org.springframework.mock.http.client.MockClientHttpRequest;
@@ -86,15 +85,15 @@ void simple() {
8685

8786
@Test
8887
void doNotReplaceCustomRequestFactory() {
89-
RestTemplateBuilder builder = new RestTemplateBuilder().requestFactory(OkHttp3ClientHttpRequestFactory.class);
88+
RestTemplateBuilder builder = new RestTemplateBuilder().requestFactory(TestClientHttpRequestFactory.class);
9089
TestRestTemplate testRestTemplate = new TestRestTemplate(builder);
9190
assertThat(testRestTemplate.getRestTemplate().getRequestFactory())
92-
.isInstanceOf(OkHttp3ClientHttpRequestFactory.class);
91+
.isInstanceOf(TestClientHttpRequestFactory.class);
9392
}
9493

9594
@Test
9695
void useTheSameRequestFactoryClassWithBasicAuth() {
97-
OkHttp3ClientHttpRequestFactory customFactory = new OkHttp3ClientHttpRequestFactory();
96+
TestClientHttpRequestFactory customFactory = new TestClientHttpRequestFactory();
9897
RestTemplateBuilder builder = new RestTemplateBuilder().requestFactory(() -> customFactory);
9998
TestRestTemplate testRestTemplate = new TestRestTemplate(builder).withBasicAuth("test", "test");
10099
RestTemplate restTemplate = testRestTemplate.getRestTemplate();
@@ -386,4 +385,8 @@ interface TestRestTemplateCallback {
386385

387386
}
388387

388+
static class TestClientHttpRequestFactory extends SimpleClientHttpRequestFactory {
389+
390+
}
391+
389392
}

0 commit comments

Comments
 (0)