Skip to content

Commit 3e3ea91

Browse files
committed
Merge pull request #31539 from izeye
* pr/31539: Disable incompatible tests on macOS AArch64 Closes gh-31539
2 parents 8c47089 + f591c75 commit 3e3ea91

File tree

3 files changed

+15
-10
lines changed

3 files changed

+15
-10
lines changed

spring-boot-project/spring-boot-tools/spring-boot-test-support/src/main/java/org/springframework/boot/testsupport/junit/DisabledOnOs.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
* See {@link org.junit.jupiter.api.condition.DisabledOnOs#value()}.
4141
* @return os
4242
*/
43-
OS os();
43+
OS[] os();
4444

4545
/**
4646
* Architecture of the operating system.

spring-boot-project/spring-boot-tools/spring-boot-test-support/src/main/java/org/springframework/boot/testsupport/junit/DisabledOnOsCondition.java

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818

1919
import java.util.Optional;
2020

21+
import org.junit.jupiter.api.condition.OS;
2122
import org.junit.jupiter.api.extension.ConditionEvaluationResult;
2223
import org.junit.jupiter.api.extension.ExecutionCondition;
2324
import org.junit.jupiter.api.extension.ExtensionContext;
@@ -42,11 +43,15 @@ public ConditionEvaluationResult evaluateExecutionCondition(ExtensionContext con
4243
private ConditionEvaluationResult evaluate(DisabledOnOs annotation) {
4344
String architecture = System.getProperty("os.arch");
4445
String os = System.getProperty("os.name");
45-
if (annotation.os().isCurrentOs() && annotation.architecture().equals(architecture)) {
46-
String reason = annotation.disabledReason().isEmpty()
47-
? String.format("Disabled on OS = %s, architecture = %s", os, architecture)
48-
: annotation.disabledReason();
49-
return ConditionEvaluationResult.disabled(reason);
46+
if (annotation.architecture().equals(architecture)) {
47+
for (OS targetOs : annotation.os()) {
48+
if (targetOs.isCurrentOs()) {
49+
String reason = annotation.disabledReason().isEmpty()
50+
? String.format("Disabled on OS = %s, architecture = %s", os, architecture)
51+
: annotation.disabledReason();
52+
return ConditionEvaluationResult.disabled(reason);
53+
}
54+
}
5055
}
5156
return ConditionEvaluationResult
5257
.enabled(String.format("Enabled on OS = %s, architecture = %s", os, architecture));

spring-boot-project/spring-boot/src/test/java/org/springframework/boot/web/embedded/jetty/SslServerCustomizerTests.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,8 @@ void whenHttp2IsNotEnabledServerConnectorHasSslAndHttpConnectionFactories() {
5757

5858
@Test
5959
@SuppressWarnings("rawtypes")
60-
@DisabledOnOs(os = OS.LINUX, architecture = "aarch64",
61-
disabledReason = "conscrypt doesn't support Linux aarch64, see https://github.com/google/conscrypt/issues/1051")
60+
@DisabledOnOs(os = { OS.LINUX, OS.MAC }, architecture = "aarch64",
61+
disabledReason = "conscrypt doesn't support Linux/macOS aarch64, see https://github.com/google/conscrypt/issues/1051")
6262
void whenHttp2IsEnabledServerConnectorsHasSslAlpnH2AndHttpConnectionFactories() {
6363
Http2 http2 = new Http2();
6464
http2.setEnabled(true);
@@ -71,8 +71,8 @@ void whenHttp2IsEnabledServerConnectorsHasSslAlpnH2AndHttpConnectionFactories()
7171
}
7272

7373
@Test
74-
@DisabledOnOs(os = OS.LINUX, architecture = "aarch64",
75-
disabledReason = "conscrypt doesn't support Linux aarch64, see https://github.com/google/conscrypt/issues/1051")
74+
@DisabledOnOs(os = { OS.LINUX, OS.MAC }, architecture = "aarch64",
75+
disabledReason = "conscrypt doesn't support Linux/macOS aarch64, see https://github.com/google/conscrypt/issues/1051")
7676
void alpnConnectionFactoryHasNullDefaultProtocolToAllowNegotiationToHttp11() {
7777
Http2 http2 = new Http2();
7878
http2.setEnabled(true);

0 commit comments

Comments
 (0)