Skip to content

Commit 0aeea6f

Browse files
committed
Increase timeouts in ZipkinWebClientSenderTests
This is an attempt to stabilize the tests. They are currently flaky due to a timeout that appears to occur because the mock web server isn't responding quickly enough. A larger timeout will either confirm this if the tests stabilize or indicate that the problem has a different cause if they do not stabilize. Closes gh-42375
1 parent 319e33f commit 0aeea6f

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/tracing/zipkin/ZipkinHttpSenderTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ public void onError(Throwable t) {
9191
callbackResult.set(new CallbackResult(false, t));
9292
}
9393
});
94-
return Awaitility.await().atMost(Duration.ofSeconds(5)).until(callbackResult::get, Objects::nonNull);
94+
return Awaitility.await().atMost(Duration.ofMinutes(1)).until(callbackResult::get, Objects::nonNull);
9595
}
9696

9797
protected void makeSyncRequest(List<byte[]> encodedSpans) throws IOException {

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/tracing/zipkin/ZipkinWebClientSenderTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ void beforeEach() {
8080

8181
@Override
8282
Sender createSender() {
83-
return createSender(Duration.ofSeconds(10));
83+
return createSender(Duration.ofMinutes(1));
8484
}
8585

8686
Sender createSender(Duration timeout) {

0 commit comments

Comments
 (0)