Skip to content

setRepository() in RepositoryItemReader in 3.0.0.RC1 broken? [BATCH-2232] #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spring-projects-issues opened this issue May 14, 2014 · 1 comment

Comments

@spring-projects-issues
Copy link
Collaborator

Shiro opened BATCH-2232 and commented

Commit b26d272 changed setRepository() from ```
public void setRepository(PagingAndSortingRepository repository)

```public void setRepository(PagingAndSortingRepository<T, ?> repository)
```.

I believe this was done in error.

For my use case I used a spring data jpa repository of type Domain but the method set with ```
setMethodName()
``` would return a String. With Milestone 1 I would declare a 
```RepositoryItemReader<String>
```, call 
```setRepository()
``` with my own 
```JpaRepository<Domain, Long>
``` and all would work as expected. With RC1 this is now impossible, because the types of the repository and the return type of the repository's query method must be the same.

No further details from BATCH-2232

@spring-projects-issues
Copy link
Collaborator Author

Michael Minella commented

Good catch! This has been resolved in the latest snapshot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant