Remove redundant modifiers

Author: fmbenhassine

spring-batch-core/src/main/java/org/springframework/batch/core/launch/JobLauncher.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2006-2022 the original author or authors.
+ * Copyright 2006-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -33,6 +33,7 @@
  * @author Lucas Ward
  * @author Dave Syer
  * @author Taeik Lim
+ * @author Mahmoud Ben Hassine
  */
 @FunctionalInterface
 public interface JobLauncher {
@@ -59,7 +60,7 @@ public interface JobLauncher {
 	 * same parameters and completed successfully
 	 * @throws JobParametersInvalidException if the parameters are not valid for this job
 	 */
-	public JobExecution run(Job job, JobParameters jobParameters) throws JobExecutionAlreadyRunningException,
+	JobExecution run(Job job, JobParameters jobParameters) throws JobExecutionAlreadyRunningException,
 			JobRestartException, JobInstanceAlreadyCompleteException, JobParametersInvalidException;
 
 }

spring-batch-core/src/main/java/org/springframework/batch/core/launch/support/ExitCodeMapper.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2006-2007 the original author or authors.
+ * Copyright 2006-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -24,25 +24,26 @@
  * @author Stijn Maller
  * @author Lucas Ward
  * @author Dave Syer
+ * @author Mahmoud Ben Hassine
  */
 public interface ExitCodeMapper {
 
-	static int JVM_EXITCODE_COMPLETED = 0;
+	int JVM_EXITCODE_COMPLETED = 0;
 
-	static int JVM_EXITCODE_GENERIC_ERROR = 1;
+	int JVM_EXITCODE_GENERIC_ERROR = 1;
 
-	static int JVM_EXITCODE_JOB_ERROR = 2;
+	int JVM_EXITCODE_JOB_ERROR = 2;
 
-	public static final String NO_SUCH_JOB = "NO_SUCH_JOB";
+	String NO_SUCH_JOB = "NO_SUCH_JOB";
 
-	public static final String JOB_NOT_PROVIDED = "JOB_NOT_PROVIDED";
+	String JOB_NOT_PROVIDED = "JOB_NOT_PROVIDED";
 
 	/**
 	 * Convert the exit code from String into an integer that the calling environment as
 	 * an operating system can interpret as an exit status.
 	 * @param exitCode The exit code which is used internally.
 	 * @return The corresponding exit status as known by the calling environment.
 	 */
-	public int intValue(String exitCode);
+	int intValue(String exitCode);
 
 }

spring-batch-core/src/main/java/org/springframework/batch/core/listener/ListenerMetaData.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2008 the original author or authors.
+ * Copyright 2002-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,20 +21,21 @@
  * A common interface for listener meta data enumerations.
  * 
  * @author Dan Garrette
+ * @author Mahmoud Ben Hassine
  * @since 2.0
  * @see JobListenerMetaData
  * @see StepListenerMetaData
  */
 public interface ListenerMetaData {
 
-	public String getMethodName();
+	String getMethodName();
 
-	public Class<? extends Annotation> getAnnotation();
+	Class<? extends Annotation> getAnnotation();
 
-	public Class<?> getListenerInterface();
+	Class<?> getListenerInterface();
 
-	public String getPropertyName();
+	String getPropertyName();
 
-	public Class<?>[] getParamTypes();
+	Class<?>[] getParamTypes();
 
 }

spring-batch-core/src/test/java/org/springframework/batch/core/configuration/annotation/StepScopeConfigurationTests.java

@@ -212,7 +212,7 @@ public String call() throws Exception {
 
 	}
 
-	public static interface ISimpleHolder {
+	public interface ISimpleHolder {
 
 		String call() throws Exception;
 

spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/orm/JpaQueryProvider.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2006-2021 the original author or authors.
+ * Copyright 2006-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -41,7 +41,7 @@ public interface JpaQueryProvider {
 	 * </p>
 	 * @return created query
 	 */
-	public Query createQuery();
+	Query createQuery();
 
 	/**
 	 * Provide an {@link EntityManager} for the query to be built.

spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/support/DataFieldMaxValueIncrementerFactory.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2006-2008 the original author or authors.
+ * Copyright 2006-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -22,6 +22,7 @@
  * provided string.
  *
  * @author Lucas Ward
+ * @author Mahmoud Ben Hassine
  *
  */
 public interface DataFieldMaxValueIncrementerFactory {
@@ -35,7 +36,7 @@ public interface DataFieldMaxValueIncrementerFactory {
 	 * @throws IllegalArgumentException if databaseType is invalid type, or
 	 * incrementerName is null.
 	 */
-	public DataFieldMaxValueIncrementer getIncrementer(String databaseType, String incrementerName);
+	DataFieldMaxValueIncrementer getIncrementer(String databaseType, String incrementerName);
 
 	/**
 	 * Returns boolean indicated whether or not the provided string is supported by this
@@ -44,12 +45,12 @@ public interface DataFieldMaxValueIncrementerFactory {
 	 * @return true if the incrementerType is supported by this database type. Else false
 	 * is returned.
 	 */
-	public boolean isSupportedIncrementerType(String databaseType);
+	boolean isSupportedIncrementerType(String databaseType);
 
 	/**
 	 * Returns the list of supported database incrementer types
 	 * @return an array of {@link String}s containing the supported incrementer types.
 	 */
-	public String[] getSupportedIncrementerTypes();
+	String[] getSupportedIncrementerTypes();
 
 }

spring-batch-infrastructure/src/main/java/org/springframework/batch/item/mail/MailErrorHandler.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2006-2010 the original author or authors.
+ * Copyright 2006-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -24,6 +24,7 @@
  *
  * @author Dan Garrette
  * @author Dave Syer
+ * @author Mahmoud Ben Hassine
  * @since 2.1
  */
 public interface MailErrorHandler {
@@ -37,6 +38,6 @@ public interface MailErrorHandler {
 	 * @param exception the exception that caused the failure
 	 * @throws MailException if the exception cannot be handled
 	 */
-	public void handle(MailMessage message, Exception exception) throws MailException;
+	void handle(MailMessage message, Exception exception) throws MailException;
 
 }

spring-batch-infrastructure/src/main/java/org/springframework/batch/repeat/RepeatStatus.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2006-2007 the original author or authors.
+ * Copyright 2006-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -29,7 +29,7 @@ public enum RepeatStatus {
 
 	private final boolean continuable;
 
-	private RepeatStatus(boolean continuable) {
+	RepeatStatus(boolean continuable) {
 		this.continuable = continuable;
 	}
 

spring-batch-infrastructure/src/main/java/org/springframework/batch/repeat/exception/LogOrRethrowExceptionHandler.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2006-2007 the original author or authors.
+ * Copyright 2006-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -29,6 +29,7 @@
  * classifier must be the same as the static enum in this class.
  *
  * @author Dave Syer
+ * @author Mahmoud Ben Hassine
  *
  */
 public class LogOrRethrowExceptionHandler implements ExceptionHandler {
@@ -39,7 +40,7 @@ public class LogOrRethrowExceptionHandler implements ExceptionHandler {
 	 * @author Dave Syer
 	 *
 	 */
-	public static enum Level {
+	public enum Level {
 
 		/**
 		 * Key for {@link Classifier} signalling that the throwable should be rethrown. If

spring-batch-infrastructure/src/main/java/org/springframework/batch/repeat/support/ResultQueue.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2022 the original author or authors.
+ * Copyright 2002-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -79,6 +79,6 @@ interface ResultQueue<T> {
 	 * when it is finished.
 	 * @return true if more results are expected, but possibly not yet available.
 	 */
-	public boolean isExpecting();
+	boolean isExpecting();
 
 }

spring-batch-infrastructure/src/main/java/org/springframework/batch/support/DatabaseType.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2006-2022 the original author or authors.
+ * Copyright 2006-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -52,7 +52,7 @@ public enum DatabaseType {
 	// in metadata.
 	private final String productName;
 
-	private DatabaseType(String productName) {
+	DatabaseType(String productName) {
 		this.productName = productName;
 	}
 

spring-batch-infrastructure/src/test/java/org/springframework/batch/container/jms/BatchMessageListenerContainer.java

@@ -57,7 +57,7 @@ public class BatchMessageListenerContainer extends DefaultMessageListenerContain
 	 * @author Dave Syer
 	 *
 	 */
-	public static interface ContainerDelegate {
+	public interface ContainerDelegate {
 
 		boolean receiveAndExecute(Object invoker, Session session, MessageConsumer consumer) throws JMSException;
 

spring-batch-infrastructure/src/test/java/org/springframework/batch/item/adapter/HippyMethodInvokerTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2010-2022 the original author or authors.
+ * Copyright 2010-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -158,7 +158,7 @@ public String empty() {
 
 	}
 
-	public static interface Service {
+	public interface Service {
 
 		String getMessage(double value, String input);
 

spring-batch-infrastructure/src/test/java/org/springframework/batch/item/database/ExtendedConnectionDataSourceProxyTests.java

@@ -257,14 +257,14 @@ void unwrapForSmartDataSource() throws Exception {
 	/**
 	 * Interface implemented by the wrapped DataSource
 	 */
-	private static interface Supported {
+	private interface Supported {
 
 	}
 
 	/**
 	 * Interface *not* implemented by the wrapped DataSource
 	 */
-	private static interface Unsupported {
+	private interface Unsupported {
 
 	}
 

spring-batch-infrastructure/src/test/java/org/springframework/batch/support/AnnotationMethodResolverTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2022 the original author or authors.
+ * Copyright 2002-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -30,6 +30,7 @@
 
 /**
  * @author Mark Fisher
+ * @author Mahmoud Ben Hassine
  */
 class AnnotationMethodResolverTests {
 
@@ -55,7 +56,7 @@ void noAnnotations() {
 
 	@Target(ElementType.METHOD)
 	@Retention(RetentionPolicy.RUNTIME)
-	private static @interface TestAnnotation {
+	private @interface TestAnnotation {
 
 	}
 

spring-batch-samples/src/main/java/org/springframework/batch/sample/domain/trade/CustomerOperation.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2006-2014 the original author or authors.
+ * Copyright 2006-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -23,6 +23,7 @@
  * Enum representing on of 3 possible actions on a customer update: Add, update, or delete
  *
  * @author Lucas Ward
+ * @author Mahmoud Ben Hassine
  *
  */
 public enum CustomerOperation {
@@ -33,7 +34,7 @@ public enum CustomerOperation {
 
 	private static final Map<Character, CustomerOperation> CODE_MAP;
 
-	private CustomerOperation(char code) {
+	CustomerOperation(char code) {
 		this.code = code;
 	}