RESOLVED - BATCH-1856: ExtendedConnectionDataSourceProxy compilation

error in JDK 7

fix Java 5 compilation regression

Author: robokaso

spring-batch-infrastructure/src/main/java/org/springframework/batch/item/database/ExtendedConnectionDataSourceProxy.java

@@ -23,7 +23,6 @@
 import java.lang.reflect.Proxy;
 import java.sql.Connection;
 import java.sql.SQLException;
-import java.sql.SQLFeatureNotSupportedException;
 import java.util.logging.Logger;
 
 import javax.sql.DataSource;
@@ -323,8 +322,13 @@ public void afterPropertiesSet() throws Exception {
 		Assert.notNull(dataSource);
 	}
 
-	public Logger getParentLogger() throws SQLFeatureNotSupportedException {
-		throw new SQLFeatureNotSupportedException();
+	/**
+	 * Added due to JDK 7 compatibility, sadly a proper implementation
+	 * that would throw SqlFeatureNotSupportedException is not possible
+	 * in Java 5 (the class was added in Java 6).
+	 */
+	public Logger getParentLogger() {
+		throw new UnsupportedOperationException();
 	}
 
 }

spring-batch-infrastructure/src/test/java/org/springframework/batch/item/database/ExtendedConnectionDataSourceProxyTests.java

@@ -1,13 +1,20 @@
 package org.springframework.batch.item.database;
 
-import static org.easymock.EasyMock.*;
-import static org.junit.Assert.*;
+import static org.easymock.EasyMock.createMock;
+import static org.easymock.EasyMock.expect;
+import static org.easymock.EasyMock.replay;
+import static org.easymock.EasyMock.verify;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNotSame;
+import static org.junit.Assert.assertSame;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
 
 import java.io.PrintWriter;
 import java.sql.Connection;
 import java.sql.ResultSet;
 import java.sql.SQLException;
-import java.sql.SQLFeatureNotSupportedException;
 import java.sql.Statement;
 import java.util.logging.Logger;
 
@@ -333,8 +340,13 @@ public <T> T unwrap(Class<T> iface) throws SQLException {
 			throw new SQLException(UNWRAP_ERROR_MESSAGE);
 		}
 
-		public Logger getParentLogger() throws SQLFeatureNotSupportedException {
-			throw new SQLFeatureNotSupportedException();
+		/**
+		 * Added due to JDK 7 compatibility, sadly a proper implementation
+		 * that would throw SqlFeatureNotSupportedException is not possible
+		 * in Java 5 (the class was added in Java 6).
+		 */
+		public Logger getParentLogger() {
+			throw new UnsupportedOperationException();
 		}
 
 	}