Skip to content

Commit 74d5b1c

Browse files
committed
Change JobBuilerHelper#enhance parameter type to AbstractJob
1 parent c0547c6 commit 74d5b1c

File tree

1 file changed

+27
-33
lines changed

1 file changed

+27
-33
lines changed

spring-batch-core/src/main/java/org/springframework/batch/core/job/builder/JobBuilderHelper.java

Lines changed: 27 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
*
4545
* @author Dave Syer
4646
* @author Mahmoud Ben Hassine
47+
* @author Taeik Lim
4748
* @since 2.2
4849
*/
4950
public abstract class JobBuilderHelper<B extends JobBuilderHelper<B>> {
@@ -182,42 +183,35 @@ protected boolean isRestartable() {
182183
return properties.restartable;
183184
}
184185

185-
protected void enhance(Job target) {
186-
187-
if (target instanceof AbstractJob) {
188-
189-
AbstractJob job = (AbstractJob) target;
190-
job.setJobRepository(properties.getJobRepository());
191-
192-
JobParametersIncrementer jobParametersIncrementer = properties.getJobParametersIncrementer();
193-
if (jobParametersIncrementer != null) {
194-
job.setJobParametersIncrementer(jobParametersIncrementer);
195-
}
196-
JobParametersValidator jobParametersValidator = properties.getJobParametersValidator();
197-
if (jobParametersValidator != null) {
198-
job.setJobParametersValidator(jobParametersValidator);
199-
}
200-
ObservationRegistry observationRegistry = properties.getObservationRegistry();
201-
if (observationRegistry != null) {
202-
job.setObservationRegistry(observationRegistry);
203-
}
204-
MeterRegistry meterRegistry = properties.getMeterRegistry();
205-
if (meterRegistry != null) {
206-
job.setMeterRegistry(meterRegistry);
207-
}
208-
209-
Boolean restartable = properties.getRestartable();
210-
if (restartable != null) {
211-
job.setRestartable(restartable);
212-
}
213-
214-
List<JobExecutionListener> listeners = properties.getJobExecutionListeners();
215-
if (!listeners.isEmpty()) {
216-
job.setJobExecutionListeners(listeners.toArray(new JobExecutionListener[0]));
217-
}
186+
protected void enhance(AbstractJob job) {
187+
job.setJobRepository(properties.getJobRepository());
218188

189+
JobParametersIncrementer jobParametersIncrementer = properties.getJobParametersIncrementer();
190+
if (jobParametersIncrementer != null) {
191+
job.setJobParametersIncrementer(jobParametersIncrementer);
192+
}
193+
JobParametersValidator jobParametersValidator = properties.getJobParametersValidator();
194+
if (jobParametersValidator != null) {
195+
job.setJobParametersValidator(jobParametersValidator);
196+
}
197+
ObservationRegistry observationRegistry = properties.getObservationRegistry();
198+
if (observationRegistry != null) {
199+
job.setObservationRegistry(observationRegistry);
200+
}
201+
MeterRegistry meterRegistry = properties.getMeterRegistry();
202+
if (meterRegistry != null) {
203+
job.setMeterRegistry(meterRegistry);
219204
}
220205

206+
Boolean restartable = properties.getRestartable();
207+
if (restartable != null) {
208+
job.setRestartable(restartable);
209+
}
210+
211+
List<JobExecutionListener> listeners = properties.getJobExecutionListeners();
212+
if (!listeners.isEmpty()) {
213+
job.setJobExecutionListeners(listeners.toArray(new JobExecutionListener[0]));
214+
}
221215
}
222216

223217
public static class CommonJobProperties {

0 commit comments

Comments
 (0)