Polish d65203e

* Minor formatting update
* Use a regexp to discard xml header in tests

Author: fmbenhassine

spring-batch-infrastructure/src/main/java/org/springframework/batch/item/xml/StaxEventItemWriter.java

@@ -73,6 +73,7 @@
  * @author Robert Kasanicky
  * @author Michael Minella
  * @author Parikshit Dutta
+ * @author Mahmoud Ben Hassine
  */
 public class StaxEventItemWriter<T> extends AbstractItemStreamItemWriter<T> implements
 ResourceAwareItemWriterItemStream<T>, InitializingBean {
@@ -635,7 +636,7 @@ protected void startDocument(XMLEventWriter writer) throws XMLStreamException {
 		XMLEventFactory factory = createXmlEventFactory();
 
 		// write start document
-		if (getStandalone()==null) {
+		if (getStandalone() == null) {
 			writer.add(factory.createStartDocument(getEncoding(), getVersion()));
 		}
 		else {

spring-batch-infrastructure/src/main/java/org/springframework/batch/item/xml/builder/StaxEventItemWriterBuilder.java

@@ -28,6 +28,7 @@
  *
  * @author Michael Minella
  * @author Parikshit Dutta
+ * @author Mahmoud Ben Hassine
  * @since 4.0
  * @see StaxEventItemWriter
  */
@@ -200,7 +201,7 @@ public StaxEventItemWriterBuilder<T> version(String version) {
 	}
 
 	/**
-	 * Standalone document declaration for the output document. Defaults to null.
+	 * Standalone document declaration for the output document. Defaults to {@code null}.
 	 *
 	 * @param standalone Boolean standalone document declaration
 	 * @return the current instance of the builder

spring-batch-infrastructure/src/test/java/org/springframework/batch/item/xml/StaxEventItemWriterTests.java

@@ -57,6 +57,7 @@
  * Tests for {@link StaxEventItemWriter}.
  *
  * @author Parikshit Dutta
+ * @author Mahmoud Ben Hassine
  */
 public class StaxEventItemWriterTests {
 
@@ -1024,13 +1025,7 @@ private String getOutputFileContent(String encoding) throws IOException {
 	private String getOutputFileContent(String encoding, boolean discardHeader) throws IOException {
 		String value = FileUtils.readFileToString(resource.getFile(), encoding);
 		if (discardHeader) {
-			// standalone is omitted if not explicitly set, meaning it will be 'yes'/'no' or no standalone attribute
-			if (value.contains("standalone")) {
-				boolean standalone = value.contains("standalone='yes'");
-				return value.replace("<?xml version='1.0' encoding='" + encoding + "' " +
-						(standalone ? "standalone='yes'" : "standalone='no'") + "?>", "");
-			}
-			return value.replace("<?xml version='1.0' encoding='" + encoding + "'?>", "");
+			return value.replaceFirst("<\\?xml.*?\\?>", "");
 		}
 		return value;
 	}

spring-batch-infrastructure/src/test/java/org/springframework/batch/item/xml/builder/StaxEventItemWriterBuilderTests.java

@@ -47,6 +47,7 @@
 /**
  * @author Michael Minella
  * @author Parikshit Dutta
+ * @author Mahmoud Ben Hassine
  */
 public class StaxEventItemWriterBuilderTests {
 
@@ -240,7 +241,7 @@ public void testStandaloneDeclarationInHeaderWhenNotSet() throws Exception {
 		staxEventItemWriter.write(this.items);
 		staxEventItemWriter.close();
 
-		String output = getOutputFileContent(staxEventItemWriter.getEncoding(), false);
+		String output = getOutputFileContent(staxEventItemWriter.getEncoding());
 		assertFalse(output.contains("standalone="));
 	}
 
@@ -260,7 +261,7 @@ public void testStandaloneDeclarationInHeaderWhenSetToTrue() throws Exception {
 		staxEventItemWriter.write(this.items);
 		staxEventItemWriter.close();
 
-		String output = getOutputFileContent(staxEventItemWriter.getEncoding(), false);
+		String output = getOutputFileContent(staxEventItemWriter.getEncoding());
 		assertTrue(output.contains("standalone='yes'"));
 	}
 
@@ -280,31 +281,16 @@ public void testStandaloneDeclarationInHeaderWhenSetToFalse() throws Exception {
 		staxEventItemWriter.write(this.items);
 		staxEventItemWriter.close();
 
-		String output = getOutputFileContent(staxEventItemWriter.getEncoding(), false);
+		String output = getOutputFileContent(staxEventItemWriter.getEncoding());
 		assertTrue(output.contains("standalone='no'"));
 	}
 
-	private String getOutputFileContent(String encoding) throws IOException {
-		return getOutputFileContent(encoding, true);
-	}
-
 	/**
 	 * @param encoding the encoding
-	 * @param discardHeader the flag to strip XML header
 	 * @return output file content as String
 	 */
-	private String getOutputFileContent(String encoding, boolean discardHeader) throws IOException {
-		String value = FileUtils.readFileToString(resource.getFile(), encoding);
-		if (discardHeader) {
-			// standalone is omitted if not explicitly set, meaning it will be 'yes'/'no' or no standalone attribute
-			if (value.contains("standalone")) {
-				boolean standalone = value.contains("standalone='yes'");
-				return value.replace("<?xml version='1.0' encoding='" + encoding + "' " +
-						(standalone ? "standalone='yes'" : "standalone='no'") + "?>", "");
-			}
-			return value.replace("<?xml version='1.0' encoding='" + encoding + "'?>", "");
-		}
-		return value;
+	private String getOutputFileContent(String encoding) throws IOException {
+		return FileUtils.readFileToString(resource.getFile(), encoding);
 	}
 
 	@XmlRootElement(name="item", namespace="https://www.springframework.org/test")