Skip to content

Commit 4a94689

Browse files
committed
Revert adding a JobRegistryBPP in the default batch configuration
Related to #4245
1 parent 15069aa commit 4a94689

File tree

3 files changed

+0
-33
lines changed

3 files changed

+0
-33
lines changed

spring-batch-core/src/main/java/org/springframework/batch/core/configuration/annotation/BatchRegistrar.java

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222

2323
import org.springframework.batch.core.configuration.support.AutomaticJobRegistrar;
2424
import org.springframework.batch.core.configuration.support.DefaultJobLoader;
25-
import org.springframework.batch.core.configuration.support.JobRegistryBeanPostProcessor;
2625
import org.springframework.batch.core.configuration.support.MapJobRegistry;
2726
import org.springframework.batch.core.explore.support.JobExplorerFactoryBean;
2827
import org.springframework.batch.core.launch.support.JobOperatorFactoryBean;
@@ -62,7 +61,6 @@ public void registerBeanDefinitions(AnnotationMetadata importingClassMetadata, B
6261
registerJobExplorer(registry, batchAnnotation, importingClassName);
6362
registerJobLauncher(registry, batchAnnotation, importingClassName);
6463
registerJobRegistry(registry);
65-
registerJobRegistryBeanPostProcessor(registry);
6664
registerJobOperator(registry, batchAnnotation);
6765
registerAutomaticJobRegistrar(registry, batchAnnotation);
6866
watch.stop();
@@ -212,19 +210,6 @@ private void registerJobRegistry(BeanDefinitionRegistry registry) {
212210
registry.registerBeanDefinition("jobRegistry", beanDefinition);
213211
}
214212

215-
private void registerJobRegistryBeanPostProcessor(BeanDefinitionRegistry registry) {
216-
if (registry.containsBeanDefinition("jobRegistryBeanPostProcessor")) {
217-
LOGGER.info("Bean jobRegistryBeanPostProcessor already defined in the application context, skipping"
218-
+ " the registration of a jobRegistryBeanPostProcessor");
219-
return;
220-
}
221-
BeanDefinitionBuilder beanDefinitionBuilder = BeanDefinitionBuilder
222-
.genericBeanDefinition(JobRegistryBeanPostProcessor.class);
223-
beanDefinitionBuilder.addPropertyReference("jobRegistry", "jobRegistry");
224-
225-
registry.registerBeanDefinition("jobRegistryBeanPostProcessor", beanDefinitionBuilder.getBeanDefinition());
226-
}
227-
228213
private void registerJobOperator(BeanDefinitionRegistry registry, EnableBatchProcessing batchAnnotation) {
229214
if (registry.containsBeanDefinition("jobOperator")) {
230215
LOGGER.info("Bean jobOperator already defined in the application context, skipping"

spring-batch-core/src/main/java/org/springframework/batch/core/configuration/annotation/EnableBatchProcessing.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -91,10 +91,6 @@
9191
* <li>a {@link org.springframework.batch.core.launch.JobOperator} (bean name
9292
* "jobOperator" of type
9393
* {@link org.springframework.batch.core.launch.support.SimpleJobOperator})</li>
94-
* <li>a
95-
* {@link org.springframework.batch.core.configuration.support.JobRegistryBeanPostProcessor}
96-
* (bean name "jobRegistryBeanPostProcessor" of type
97-
* {@link org.springframework.batch.core.configuration.support.JobRegistryBeanPostProcessor})</li>
9894
* </ul>
9995
*
10096
* If the configuration is specified as <code>modular=true</code>, the context also

spring-batch-core/src/main/java/org/springframework/batch/core/configuration/support/DefaultBatchConfiguration.java

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@
7676
* <li>a {@link JobLauncher} named "jobLauncher"</li>
7777
* <li>a {@link JobRegistry} named "jobRegistry"</li>
7878
* <li>a {@link JobOperator} named "JobOperator"</li>
79-
* <li>a {@link JobRegistryBeanPostProcessor} named "jobRegistryBeanPostProcessor"</li>
8079
* <li>a {@link org.springframework.batch.core.scope.StepScope} named "stepScope"</li>
8180
* <li>a {@link org.springframework.batch.core.scope.JobScope} named "jobScope"</li>
8281
* </ul>
@@ -202,19 +201,6 @@ public JobOperator jobOperator() throws BatchConfigurationException {
202201
}
203202
}
204203

205-
@Bean
206-
public JobRegistryBeanPostProcessor jobRegistryBeanPostProcessor() throws BatchConfigurationException {
207-
JobRegistryBeanPostProcessor jobRegistryBeanPostProcessor = new JobRegistryBeanPostProcessor();
208-
jobRegistryBeanPostProcessor.setJobRegistry(jobRegistry());
209-
try {
210-
jobRegistryBeanPostProcessor.afterPropertiesSet();
211-
return jobRegistryBeanPostProcessor;
212-
}
213-
catch (Exception e) {
214-
throw new BatchConfigurationException("Unable to configure the default job registry BeanPostProcessor", e);
215-
}
216-
}
217-
218204
/*
219205
* Getters to customize the configuration of infrastructure beans
220206
*/

0 commit comments

Comments
 (0)