Change type of timestamp fields in JobExecution/StepExecution to LocalDateTime

This commit changes the type of fields `startTime`, `endTime`,
`createTime` and `lastUpdated` in `JobExecution` and `StepExecution`
from `java.util.Date` to `java.time.LocalDateTime`.

Resolves #1014

Author: fmbenhassine

spring-batch-core/src/main/java/org/springframework/batch/core/JobExecution.java

@@ -18,10 +18,10 @@
 
 import java.io.IOException;
 import java.io.ObjectInputStream;
+import java.time.LocalDateTime;
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.Collections;
-import java.util.Date;
 import java.util.HashSet;
 import java.util.LinkedHashSet;
 import java.util.List;
@@ -52,13 +52,13 @@ public class JobExecution extends Entity {
 
 	private volatile BatchStatus status = BatchStatus.STARTING;
 
-	private volatile Date startTime = null;
+	private volatile LocalDateTime startTime = null;
 
-	private volatile Date createTime = new Date(System.currentTimeMillis());
+	private volatile LocalDateTime createTime = LocalDateTime.now();
 
-	private volatile Date endTime = null;
+	private volatile LocalDateTime endTime = null;
 
-	private volatile Date lastUpdated = null;
+	private volatile LocalDateTime lastUpdated = null;
 
 	private volatile ExitStatus exitStatus = ExitStatus.UNKNOWN;
 
@@ -140,7 +140,7 @@ public JobParameters getJobParameters() {
 	 * @return The current end time.
 	 */
 	@Nullable
-	public Date getEndTime() {
+	public LocalDateTime getEndTime() {
 		return endTime;
 	}
 
@@ -154,25 +154,25 @@ public void setJobInstance(JobInstance jobInstance) {
 
 	/**
 	 * Set the end time.
-	 * @param endTime The {@link Date} to be used for the end time.
+	 * @param endTime The {@link LocalDateTime} to be used for the end time.
 	 */
-	public void setEndTime(Date endTime) {
+	public void setEndTime(LocalDateTime endTime) {
 		this.endTime = endTime;
 	}
 
 	/**
 	 * @return The current start time.
 	 */
 	@Nullable
-	public Date getStartTime() {
+	public LocalDateTime getStartTime() {
 		return startTime;
 	}
 
 	/**
 	 * Set the start time.
-	 * @param startTime The {@link Date} to be used for the start time.
+	 * @param startTime The {@link LocalDateTime} to be used for the start time.
 	 */
-	public void setStartTime(Date startTime) {
+	public void setStartTime(LocalDateTime startTime) {
 		this.startTime = startTime;
 	}
 
@@ -290,14 +290,14 @@ public ExecutionContext getExecutionContext() {
 	/**
 	 * @return the time when this execution was created.
 	 */
-	public Date getCreateTime() {
+	public LocalDateTime getCreateTime() {
 		return createTime;
 	}
 
 	/**
 	 * @param createTime The creation time of this execution.
 	 */
-	public void setCreateTime(Date createTime) {
+	public void setCreateTime(LocalDateTime createTime) {
 		this.createTime = createTime;
 	}
 
@@ -313,20 +313,20 @@ void addStepExecution(StepExecution stepExecution) {
 	/**
 	 * Get the date representing the last time this {@code JobExecution} was updated in
 	 * the {@link org.springframework.batch.core.repository.JobRepository}.
-	 * @return a {@code Date} object representing the last time this {@code JobExecution}
-	 * was updated.
+	 * @return a {@link LocalDateTime} object representing the last time this
+	 * {@code JobExecution} was updated.
 	 */
 	@Nullable
-	public Date getLastUpdated() {
+	public LocalDateTime getLastUpdated() {
 		return lastUpdated;
 	}
 
 	/**
 	 * Set the last time this {@code JobExecution} was updated.
-	 * @param lastUpdated The {@link Date} instance to which to set the job execution's
-	 * {@code lastUpdated} attribute.
+	 * @param lastUpdated The {@link LocalDateTime} instance to which to set the job
+	 * execution's {@code lastUpdated} attribute.
 	 */
-	public void setLastUpdated(Date lastUpdated) {
+	public void setLastUpdated(LocalDateTime lastUpdated) {
 		this.lastUpdated = lastUpdated;
 	}
 

spring-batch-core/src/main/java/org/springframework/batch/core/StepExecution.java

@@ -18,8 +18,8 @@
 
 import java.io.IOException;
 import java.io.ObjectInputStream;
+import java.time.LocalDateTime;
 import java.util.ArrayList;
-import java.util.Date;
 import java.util.List;
 import java.util.concurrent.CopyOnWriteArrayList;
 
@@ -61,13 +61,13 @@ public class StepExecution extends Entity {
 
 	private volatile long writeSkipCount = 0;
 
-	private volatile Date startTime = null;
+	private volatile LocalDateTime startTime = null;
 
-	private volatile Date createTime = new Date(System.currentTimeMillis());
+	private volatile LocalDateTime createTime = LocalDateTime.now();
 
-	private volatile Date endTime = null;
+	private volatile LocalDateTime endTime = null;
 
-	private volatile Date lastUpdated = null;
+	private volatile LocalDateTime lastUpdated = null;
 
 	private volatile ExecutionContext executionContext = new ExecutionContext();
 
@@ -156,15 +156,15 @@ public void setCommitCount(long commitCount) {
 	 * @return the time when this execution ended or {@code null} if the step is running.
 	 */
 	@Nullable
-	public Date getEndTime() {
+	public LocalDateTime getEndTime() {
 		return endTime;
 	}
 
 	/**
 	 * Sets the time when this execution ended.
 	 * @param endTime The time when this execution ended.
 	 */
-	public void setEndTime(Date endTime) {
+	public void setEndTime(LocalDateTime endTime) {
 		this.endTime = endTime;
 	}
 
@@ -236,15 +236,15 @@ public void setRollbackCount(long rollbackCount) {
 	 * Gets the time this execution was created
 	 * @return the time when this execution was created.
 	 */
-	public Date getCreateTime() {
+	public LocalDateTime getCreateTime() {
 		return createTime;
 	}
 
 	/**
 	 * Sets the time this execution was created
 	 * @param createTime creation time of this execution.
 	 */
-	public void setCreateTime(Date createTime) {
+	public void setCreateTime(LocalDateTime createTime) {
 		this.createTime = createTime;
 	}
 
@@ -253,15 +253,15 @@ public void setCreateTime(Date createTime) {
 	 * @return the time when this execution started.
 	 */
 	@Nullable
-	public Date getStartTime() {
+	public LocalDateTime getStartTime() {
 		return startTime;
 	}
 
 	/**
 	 * Sets the time when this execution started.
 	 * @param startTime The time when this execution started.
 	 */
-	public void setStartTime(Date startTime) {
+	public void setStartTime(LocalDateTime startTime) {
 		this.startTime = startTime;
 	}
 
@@ -457,16 +457,16 @@ public void setProcessSkipCount(long processSkipCount) {
 	 * @return the Date representing the last time this execution was persisted.
 	 */
 	@Nullable
-	public Date getLastUpdated() {
+	public LocalDateTime getLastUpdated() {
 		return lastUpdated;
 	}
 
 	/**
 	 * Sets the time when the {@code StepExecution} was last updated before persisting.
-	 * @param lastUpdated the {@link Date} instance used to establish the last updated
-	 * date for the {@code StepExecution}.
+	 * @param lastUpdated the {@link LocalDateTime} instance used to establish the last
+	 * updated date for the {@code StepExecution}.
 	 */
-	public void setLastUpdated(Date lastUpdated) {
+	public void setLastUpdated(LocalDateTime lastUpdated) {
 		this.lastUpdated = lastUpdated;
 	}
 

spring-batch-core/src/main/java/org/springframework/batch/core/job/AbstractJob.java

@@ -16,8 +16,8 @@
 
 package org.springframework.batch.core.job;
 
+import java.time.LocalDateTime;
 import java.util.Collection;
-import java.util.Date;
 import java.util.List;
 import java.util.stream.Collectors;
 
@@ -296,7 +296,7 @@ public final void execute(JobExecution execution) {
 
 			if (execution.getStatus() != BatchStatus.STOPPING) {
 
-				execution.setStartTime(new Date());
+				execution.setStartTime(LocalDateTime.now());
 				updateStatus(execution, BatchStatus.STARTED);
 
 				listener.beforeJob(execution);
@@ -352,7 +352,7 @@ public final void execute(JobExecution execution) {
 				}
 				stopObservation(execution, observation);
 				longTaskTimerSample.stop();
-				execution.setEndTime(new Date());
+				execution.setEndTime(LocalDateTime.now());
 
 				try {
 					listener.afterJob(execution);

spring-batch-core/src/main/java/org/springframework/batch/core/launch/support/SimpleJobOperator.java

@@ -15,8 +15,8 @@
  */
 package org.springframework.batch.core.launch.support;
 
+import java.time.LocalDateTime;
 import java.util.ArrayList;
-import java.util.Date;
 import java.util.LinkedHashMap;
 import java.util.LinkedHashSet;
 import java.util.List;
@@ -447,7 +447,7 @@ public JobExecution abandon(long jobExecutionId)
 			logger.info("Aborting job execution: " + jobExecution);
 		}
 		jobExecution.upgradeStatus(BatchStatus.ABANDONED);
-		jobExecution.setEndTime(new Date());
+		jobExecution.setEndTime(LocalDateTime.now());
 		jobRepository.update(jobExecution);
 
 		return jobExecution;

spring-batch-core/src/main/java/org/springframework/batch/core/observability/BatchMetrics.java

@@ -16,8 +16,8 @@
 package org.springframework.batch.core.observability;
 
 import java.time.Duration;
+import java.time.LocalDateTime;
 import java.util.Arrays;
-import java.util.Date;
 import java.util.concurrent.TimeUnit;
 
 import io.micrometer.core.instrument.LongTaskTimer;
@@ -142,11 +142,11 @@ public static LongTaskTimer createLongTaskTimer(String name, String description,
 	 * @return the duration between start time and end time
 	 */
 	@Nullable
-	public static Duration calculateDuration(@Nullable Date startTime, @Nullable Date endTime) {
+	public static Duration calculateDuration(@Nullable LocalDateTime startTime, @Nullable LocalDateTime endTime) {
 		if (startTime == null || endTime == null) {
 			return null;
 		}
-		return Duration.between(startTime.toInstant(), endTime.toInstant());
+		return Duration.between(startTime, endTime);
 	}
 
 	/**

spring-batch-core/src/main/java/org/springframework/batch/core/repository/dao/JdbcJobExecutionDao.java

@@ -18,7 +18,9 @@
 
 import java.sql.ResultSet;
 import java.sql.SQLException;
+import java.sql.Timestamp;
 import java.sql.Types;
+import java.time.LocalDateTime;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.List;
@@ -165,10 +167,16 @@ public void saveJobExecution(JobExecution jobExecution) {
 		jobExecution.incrementVersion();
 
 		jobExecution.setId(jobExecutionIncrementer.nextLongValue());
-		Object[] parameters = new Object[] { jobExecution.getId(), jobExecution.getJobId(), jobExecution.getStartTime(),
-				jobExecution.getEndTime(), jobExecution.getStatus().toString(),
-				jobExecution.getExitStatus().getExitCode(), jobExecution.getExitStatus().getExitDescription(),
-				jobExecution.getVersion(), jobExecution.getCreateTime(), jobExecution.getLastUpdated() };
+		Timestamp startTime = jobExecution.getStartTime() == null ? null
+				: Timestamp.valueOf(jobExecution.getStartTime());
+		Timestamp endTime = jobExecution.getEndTime() == null ? null : Timestamp.valueOf(jobExecution.getEndTime());
+		Timestamp createTime = jobExecution.getCreateTime() == null ? null
+				: Timestamp.valueOf(jobExecution.getCreateTime());
+		Timestamp lastUpdated = jobExecution.getLastUpdated() == null ? null
+				: Timestamp.valueOf(jobExecution.getLastUpdated());
+		Object[] parameters = new Object[] { jobExecution.getId(), jobExecution.getJobId(), startTime, endTime,
+				jobExecution.getStatus().toString(), jobExecution.getExitStatus().getExitCode(),
+				jobExecution.getExitStatus().getExitDescription(), jobExecution.getVersion(), createTime, lastUpdated };
 		getJdbcTemplate().update(getQuery(SAVE_JOB_EXECUTION), parameters,
 				new int[] { Types.BIGINT, Types.BIGINT, Types.TIMESTAMP, Types.TIMESTAMP, Types.VARCHAR, Types.VARCHAR,
 						Types.VARCHAR, Types.INTEGER, Types.TIMESTAMP, Types.TIMESTAMP });
@@ -217,10 +225,16 @@ public void updateJobExecution(JobExecution jobExecution) {
 					logger.debug("Truncating long message before update of JobExecution: " + jobExecution);
 				}
 			}
-			Object[] parameters = new Object[] { jobExecution.getStartTime(), jobExecution.getEndTime(),
-					jobExecution.getStatus().toString(), jobExecution.getExitStatus().getExitCode(), exitDescription,
-					version, jobExecution.getCreateTime(), jobExecution.getLastUpdated(), jobExecution.getId(),
-					jobExecution.getVersion() };
+			Timestamp startTime = jobExecution.getStartTime() == null ? null
+					: Timestamp.valueOf(jobExecution.getStartTime());
+			Timestamp endTime = jobExecution.getEndTime() == null ? null : Timestamp.valueOf(jobExecution.getEndTime());
+			Timestamp createTime = jobExecution.getCreateTime() == null ? null
+					: Timestamp.valueOf(jobExecution.getCreateTime());
+			Timestamp lastUpdated = jobExecution.getLastUpdated() == null ? null
+					: Timestamp.valueOf(jobExecution.getLastUpdated());
+			Object[] parameters = new Object[] { startTime, endTime, jobExecution.getStatus().toString(),
+					jobExecution.getExitStatus().getExitCode(), exitDescription, version, createTime, lastUpdated,
+					jobExecution.getId(), jobExecution.getVersion() };
 
 			// Check if given JobExecution's Id already exists, if none is found
 			// it
@@ -433,12 +447,12 @@ public JobExecution mapRow(ResultSet rs, int rowNum) throws SQLException {
 				jobExecution = new JobExecution(jobInstance, id, jobParameters);
 			}
 
-			jobExecution.setStartTime(rs.getTimestamp(2));
-			jobExecution.setEndTime(rs.getTimestamp(3));
+			jobExecution.setStartTime(rs.getObject(2, LocalDateTime.class));
+			jobExecution.setEndTime(rs.getObject(3, LocalDateTime.class));
 			jobExecution.setStatus(BatchStatus.valueOf(rs.getString(4)));
 			jobExecution.setExitStatus(new ExitStatus(rs.getString(5), rs.getString(6)));
-			jobExecution.setCreateTime(rs.getTimestamp(7));
-			jobExecution.setLastUpdated(rs.getTimestamp(8));
+			jobExecution.setCreateTime(rs.getObject(7, LocalDateTime.class));
+			jobExecution.setLastUpdated(rs.getObject(8, LocalDateTime.class));
 			jobExecution.setVersion(rs.getInt(9));
 			return jobExecution;
 		}