Skip to content

Add readOnly boolean on PoiItemReader #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EXAXL opened this issue Jun 18, 2024 · 1 comment
Closed

Add readOnly boolean on PoiItemReader #128

EXAXL opened this issue Jun 18, 2024 · 1 comment

Comments

@EXAXL
Copy link

EXAXL commented Jun 18, 2024

Using as-is PoiItemReader implementation force to rewrite each time input file.
Sometime you don't need it/you can not do it (in our case we can not edit a file put on a nfs).

It could be nice adding a boolean field if the workbook has to be in readOnly mode or not.
In the current implementation it is always force to false

@EXAXL EXAXL changed the title Adding readOnly boolean on PoiItemReader Add readOnly boolean on PoiItemReader Jun 18, 2024
@mdeinum
Copy link
Collaborator

mdeinum commented Aug 7, 2024

I wonder if this wouldn't just be a sensible default in the first place. The reader should only read the file not modify it. So we could argue here that we just always should open it in read-only mode. I don't expect any problems if we do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants