Skip to content

Commit a8ddf17

Browse files
committed
Apply review
1 parent d9eee35 commit a8ddf17

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

spring-batch-bigquery/pom.xml

+9-6
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,13 @@
7272
<groupId>org.springframework.batch</groupId>
7373
<artifactId>spring-batch-core</artifactId>
7474
</dependency>
75+
7576
<!-- Test -->
77+
<dependency>
78+
<groupId>ch.qos.logback</groupId>
79+
<artifactId>logback-classic</artifactId>
80+
<scope>test</scope>
81+
</dependency>
7682
<dependency>
7783
<groupId>org.junit.jupiter</groupId>
7884
<artifactId>junit-jupiter-api</artifactId>
@@ -83,12 +89,6 @@
8389
<artifactId>mockito-core</artifactId>
8490
<scope>test</scope>
8591
</dependency>
86-
<dependency>
87-
<groupId>ch.qos.logback</groupId>
88-
<artifactId>logback-classic</artifactId>
89-
<version>${logback.version}</version>
90-
<scope>test</scope>
91-
</dependency>
9292
<dependency>
9393
<groupId>org.testcontainers</groupId>
9494
<artifactId>junit-jupiter</artifactId>
@@ -98,6 +98,7 @@
9898

9999
<build>
100100
<plugins>
101+
<!-- Generate javadoc and source jars -->
101102
<plugin>
102103
<groupId>org.apache.maven.plugins</groupId>
103104
<artifactId>maven-javadoc-plugin</artifactId>
@@ -122,6 +123,7 @@
122123
</execution>
123124
</executions>
124125
</plugin>
126+
<!-- Runs tests -->
125127
<plugin>
126128
<groupId>org.apache.maven.plugins</groupId>
127129
<artifactId>maven-surefire-plugin</artifactId>
@@ -133,6 +135,7 @@
133135
</includes>
134136
</configuration>
135137
</plugin>
138+
<!-- Generates a flattened version of the pom.xml, used instead of the original -->
136139
<plugin>
137140
<groupId>org.codehaus.mojo</groupId>
138141
<artifactId>flatten-maven-plugin</artifactId>

0 commit comments

Comments
 (0)