From 17fcb44be28593ea22b9dd9c472a610bdab191bf Mon Sep 17 00:00:00 2001 From: Ujjwal Shrestha Date: Wed, 18 Oct 2023 12:29:53 -0400 Subject: [PATCH 1/4] Updated IgnoredPatterns Added support for more Rewrite recipes --- sbm-support-rewrite/pom.xml | 140 +++++++++++++++--- .../sbm/parsers/ParserProperties.java | 2 +- .../META-INF/sbm-support-rewrite.properties | 2 +- 3 files changed, 120 insertions(+), 24 deletions(-) diff --git a/sbm-support-rewrite/pom.xml b/sbm-support-rewrite/pom.xml index 4be8876c6..d8f865aaf 100644 --- a/sbm-support-rewrite/pom.xml +++ b/sbm-support-rewrite/pom.xml @@ -22,6 +22,7 @@ UTF-8 3.1.3 8.5.1 + 2.3.0 5.3.2 3.9.1 1.9.13 @@ -88,6 +89,20 @@ pom import + + org.openrewrite + rewrite-bom + ${rewrite.version} + pom + import + + + org.openrewrite.recipe + rewrite-recipe-bom + ${rewrite-recipe.version} + pom + import + @@ -107,48 +122,136 @@ org.openrewrite - rewrite-maven - ${rewrite.version} + rewrite-gradle org.openrewrite - rewrite-java - ${rewrite.version} + rewrite-groovy org.openrewrite - rewrite-java-17 - ${rewrite.version} + rewrite-hcl + + + org.openrewrite + rewrite-java + + + org.openrewrite.recipe + rewrite-java-dependencies org.openrewrite rewrite-json - ${rewrite.version} org.openrewrite - rewrite-yaml - ${rewrite.version} + rewrite-maven org.openrewrite - rewrite-hcl - ${rewrite.version} + rewrite-properties org.openrewrite rewrite-protobuf - ${rewrite.version} org.openrewrite rewrite-xml - ${rewrite.version} org.openrewrite - rewrite-properties - ${rewrite.version} + rewrite-yaml + + + + org.openrewrite.recipe + rewrite-cucumber-jvm + + + org.openrewrite.recipe + rewrite-hibernate + + + org.openrewrite.recipe + rewrite-java-security + + + org.openrewrite.recipe + rewrite-logging-frameworks + + + org.openrewrite.recipe + rewrite-micrometer + + + + org.openrewrite.recipe + rewrite-migrate-java + + + + org.openrewrite.recipe + rewrite-spring + + + org.openrewrite.recipe + rewrite-sql + + + org.openrewrite.recipe + rewrite-static-analysis + + + + org.openrewrite.recipe + rewrite-testing-frameworks + + + org.openrewrite.maven + rewrite-maven-plugin + ${rewrite-maven-plugin.version} org.projectlombok @@ -183,13 +286,6 @@ commons-cli 1.4 - - - org.openrewrite.maven - rewrite-maven-plugin - ${rewrite-maven-plugin.version} - test - org.apache.maven.wagon wagon-http diff --git a/sbm-support-rewrite/src/main/java/org/springframework/sbm/parsers/ParserProperties.java b/sbm-support-rewrite/src/main/java/org/springframework/sbm/parsers/ParserProperties.java index 1aa8cdd67..a3189da76 100644 --- a/sbm-support-rewrite/src/main/java/org/springframework/sbm/parsers/ParserProperties.java +++ b/sbm-support-rewrite/src/main/java/org/springframework/sbm/parsers/ParserProperties.java @@ -79,6 +79,6 @@ public class ParserProperties { /** * Comma-separated list of patterns used to create PathMatcher to exclude paths from being parsed. */ - private Set ignoredPathPatterns = Set.of("**/target/**", "target/**", "**/.idea/**", ".idea/**", ".mvn/**", "**/.mvn/**"); + private Set ignoredPathPatterns = Set.of("**/target/**", "target/**", "**/.idea/**", ".idea/**", "**/.git/**", ".git/**", ".mvn/**", "**/.mvn/**", "node_modules/**", "**/node_modules/**"); } diff --git a/sbm-support-rewrite/src/main/resources/META-INF/sbm-support-rewrite.properties b/sbm-support-rewrite/src/main/resources/META-INF/sbm-support-rewrite.properties index 0d564fd91..063e56bce 100644 --- a/sbm-support-rewrite/src/main/resources/META-INF/sbm-support-rewrite.properties +++ b/sbm-support-rewrite/src/main/resources/META-INF/sbm-support-rewrite.properties @@ -27,4 +27,4 @@ parser.sizeThresholdMb=10 parser.runPerSubmodule=false parser.failOnInvalidActiveRecipes=true parser.activeProfiles=default -parser.ignoredPathPatterns=**.idea,**.git,**/target/**,target/** +parser.ignoredPathPatterns=**/.idea/**,.idea/**,**/.git/**,.git/**,**/.mvn/**,.mvn/**,**/target/**,target/**,**/node_modules/**,node_modules/** From 1200075c0d55ddd715db94ce7b3409e72afdcab8 Mon Sep 17 00:00:00 2001 From: Ujjwal Shrestha Date: Thu, 19 Oct 2023 15:31:31 -0400 Subject: [PATCH 2/4] Added rewrite-maven-plugin to test scope --- sbm-support-rewrite/pom.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/sbm-support-rewrite/pom.xml b/sbm-support-rewrite/pom.xml index d8f865aaf..49be4a5b4 100644 --- a/sbm-support-rewrite/pom.xml +++ b/sbm-support-rewrite/pom.xml @@ -252,6 +252,7 @@ org.openrewrite.maven rewrite-maven-plugin ${rewrite-maven-plugin.version} + test org.projectlombok From d77441877edca812d0c63a98ba79f13337fbb5a0 Mon Sep 17 00:00:00 2001 From: Ujjwal Shrestha Date: Wed, 8 Nov 2023 11:05:12 -0500 Subject: [PATCH 3/4] Fix failed testcase --- .../org/springframework/sbm/parsers/ParserPropertiesTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sbm-support-rewrite/src/test/java/org/springframework/sbm/parsers/ParserPropertiesTest.java b/sbm-support-rewrite/src/test/java/org/springframework/sbm/parsers/ParserPropertiesTest.java index b7c9e6988..e0d650589 100644 --- a/sbm-support-rewrite/src/test/java/org/springframework/sbm/parsers/ParserPropertiesTest.java +++ b/sbm-support-rewrite/src/test/java/org/springframework/sbm/parsers/ParserPropertiesTest.java @@ -87,7 +87,7 @@ void defaultActiveProfiles() { @Test @DisplayName("parser.ignoredPathPatterns") void defaultIgnoredPathPatterns() { - assertThat(parserProperties.getIgnoredPathPatterns()).containsExactlyInAnyOrder("**.idea/**", "**.git/**", "**/target/**", "target/**"); + assertThat(parserProperties.getIgnoredPathPatterns()).containsExactlyInAnyOrder("**/target/**", "target/**", "**/.idea/**", ".idea/**", "**/.git/**", ".git/**", ".mvn/**", "**/.mvn/**", "node_modules/**", "**/node_modules/**"); } } From 61e0acd2b044fe4e20e6fe5889b05300d2174b8a Mon Sep 17 00:00:00 2001 From: Ujjwal Shrestha Date: Tue, 14 Nov 2023 14:14:43 -0500 Subject: [PATCH 4/4] Removed OR Recipe --- sbm-support-rewrite/pom.xml | 53 ------------------------------------- 1 file changed, 53 deletions(-) diff --git a/sbm-support-rewrite/pom.xml b/sbm-support-rewrite/pom.xml index fde9cc61b..7a64eeb1f 100644 --- a/sbm-support-rewrite/pom.xml +++ b/sbm-support-rewrite/pom.xml @@ -22,7 +22,6 @@ UTF-8 3.1.3 8.5.1 - 2.3.0 5.3.2 3.9.1 1.9.13 @@ -96,16 +95,8 @@ pom import - - org.openrewrite.recipe - rewrite-recipe-bom - ${rewrite-recipe.version} - pom - import - - org.springframework.boot @@ -136,10 +127,6 @@ org.openrewrite rewrite-java - - org.openrewrite.recipe - rewrite-java-dependencies - org.openrewrite rewrite-json @@ -164,46 +151,6 @@ org.openrewrite rewrite-yaml - - org.openrewrite.recipe - rewrite-cucumber-jvm - - - org.openrewrite.recipe - rewrite-hibernate - - - org.openrewrite.recipe - rewrite-java-security - - - org.openrewrite.recipe - rewrite-logging-frameworks - - - org.openrewrite.recipe - rewrite-micrometer - - - org.openrewrite.recipe - rewrite-migrate-java - - - org.openrewrite.recipe - rewrite-spring - - - org.openrewrite.recipe - rewrite-sql - - - org.openrewrite.recipe - rewrite-static-analysis - - - org.openrewrite.recipe - rewrite-testing-frameworks - org.openrewrite.maven rewrite-maven-plugin