Skip to content

Move scoped beans logic from core to support-rewrite #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fabapp2 opened this issue Aug 8, 2023 · 2 comments · Fixed by #903
Closed

Move scoped beans logic from core to support-rewrite #869

fabapp2 opened this issue Aug 8, 2023 · 2 comments · Fixed by #903
Assignees
@fabapp2
Labels
in: sbm-support-rewrite Issue is related to the sbm-support-rewrite compionent revamp type: refactoring

Comments

@fabapp2
Copy link
Contributor

fabapp2 commented Aug 8, 2023

No description provided.

@fabapp2 fabapp2 added in: sbm-support-rewrite Issue is related to the sbm-support-rewrite compionent type: enhancement New feature or request type: refactoring and removed type: enhancement New feature or request labels Aug 8, 2023
@fabapp2 fabapp2 self-assigned this Aug 8, 2023
@fabapp2
Copy link
Contributor Author

fabapp2 commented Aug 8, 2023

ScanScope and ExecutionScope were reset in Scan and ApplyCommand.
Clearing the scan scope was moved into RewriteProjectParser.
Clearing the ExecutionScope would require a central place in sbm-support-rewrite executin recipes to clear the scope there. This does currently not exist which splits the scope handling.
ScanScope is handled in sbm-support-rewrite while ExecutionScope is cleared in sbm-core, but only when using the ApplyCommand.

@fabapp2 fabapp2 added the revamp label Aug 25, 2023
@fabapp2 fabapp2 linked a pull request Aug 30, 2023 that will close this issue
869 move scoped beans logic from core to support rewrite #896
Closed
@fabapp2 fabapp2 mentioned this issue Aug 31, 2023
Closed
@fabapp2 fabapp2 linked a pull request Sep 1, 2023 that will close this issue
869 move scoped beans logic from core to support rewrite #903
Merged
@fabapp2
Copy link
Contributor Author

fabapp2 commented Sep 1, 2023

done in #896

@fabapp2 fabapp2 closed this as completed Sep 1, 2023
@github-project-automation github-project-automation bot moved this to Done in Revamp Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabapp2 fabapp2

Labels
in: sbm-support-rewrite Issue is related to the sbm-support-rewrite compionent revamp type: refactoring
Projects
Revamp
Status: Done
Milestone
No milestone
1 participant
@fabapp2