Skip to content

Ignore all resources in .gitignore when scanning #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Tracked by #844
fabapp2 opened this issue Mar 30, 2022 · 1 comment
Open
Tracked by #844

Ignore all resources in .gitignore when scanning #78

fabapp2 opened this issue Mar 30, 2022 · 1 comment
Labels
good first issue Good for newcomers in: sbm-support-rewrite Issue is related to the sbm-support-rewrite compionent type: enhancement New feature or request

Comments

@fabapp2
Copy link
Contributor

fabapp2 commented Mar 30, 2022

What needs to be done

Contents of .gitignore should be ignored when scanning a given application with PathScanner.

Why it needs to be done

Some resources and dirs (like target) are ignored by default, this can be configured by setting sbm.ignoredPathsPatterns. But all ignored resources in .gitignore should also be ignored.

Acceptance Criteria

Given the project to migrate contains a resource some-file.txt
When the .gitgnore contains some-file.txt
Then PathScanner.scan(Path) should not return the ignored resource(s)

It must handle all kinds of ignore patterns from .gitignore.

Additional Information

See sbm.ignoredPathsPatterns in components/sbm-core/src/main/resources/application-core.properties
See PathScanner
@fabapp2 fabapp2 added type: enhancement New feature or request good first issue Good for newcomers labels Mar 30, 2022
@fabapp2 fabapp2 mentioned this issue Aug 3, 2023
Open
25 tasks
@fabapp2 fabapp2 added the in: sbm-support-rewrite Issue is related to the sbm-support-rewrite compionent label Aug 3, 2023
@kiyounpark
Copy link

Hi, I'd like to work on this issue. Could you confirm if it's still open for contribution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers in: sbm-support-rewrite Issue is related to the sbm-support-rewrite compionent type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabapp2 @kiyounpark