Skip to content

Provide BuildFile.hasDependencyMatchingRegex(...) #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fabapp2 opened this issue Mar 30, 2022 · 1 comment
Closed

Provide BuildFile.hasDependencyMatchingRegex(...) #74

fabapp2 opened this issue Mar 30, 2022 · 1 comment
Labels
in: sbm-core type: enhancement New feature or request

Comments

@fabapp2
Copy link
Contributor

fabapp2 commented Mar 30, 2022

What needs to be done

Provide method buildFile.hasDependencyMatchingRegex() which considers transitive dependencies too as counterpart to buildFile.hasDeclaredDependencyMatchingRegex()

Acceptance Criteria

hasDependencyMatchingRegex

Given pom.xml contains a dependency that brings a transitive dependency
When hasDependencyMatchingRegex(<regex for the transitive dependency>) is called on this BuildFile
Then this method should return true

Given pom.xml contains a dependency that brings a transitive dependency
When hasDependencyMatchingRegex(<regex for the declared dependency>) is called on this BuildFile
Then this method should return true

hasDeclaredDependencyMatchingRegex

Given pom.xml contains a dependency that brings a transitive dependency
When hasDeclaredDependencyMatchingRegex(<regex for the transitive dependency>) is called on this BuildFile
Then this method should return false

Given pom.xml contains a dependency that brings a transitive dependency
When hasDeclaredDependencyMatchingRegex(<regex for the declared dependency>) is called on this BuildFile
Then this method should return true

Additional Information

See MigrateWlsEjbDeploymentDescriptor.incorporateIntoSourceFile():69

@fabapp2 fabapp2 added the type: enhancement New feature or request label Mar 30, 2022
@fabapp2
Copy link
Contributor Author

fabapp2 commented Aug 31, 2023

Added with #690

hasDependencyMatchingRegex -> hasEffectiveDependencyMatchingRegex
hasDeclaredDependencyMatchingRegex -> hasDeclaredDependencyMatchingRegex

@fabapp2 fabapp2 closed this as completed Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: sbm-core type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant