Skip to content

Upgrade to OpenRewrite 7.20.0 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks
fabapp2 opened this issue Mar 1, 2022 · 2 comments · Fixed by #174
Closed
2 tasks

Upgrade to OpenRewrite 7.20.0 #7

fabapp2 opened this issue Mar 1, 2022 · 2 comments · Fixed by #174
Assignees
@fabapp2
Labels
type: enhancement New feature or request

Comments

@fabapp2
Copy link
Contributor

fabapp2 commented Mar 1, 2022 •
edited
Loading

  • Fix MavenProjectParser, see https://github.com/openrewrite/rewrite-maven-plugin/blob/main/src/main/java/org/openrewrite/maven/MavenMojoProjectParser.java and code provided
  • Rework adding resources and java classes, JavaParser creates the JavaSourceSet now
@fabapp2 fabapp2 self-assigned this Mar 1, 2022
@fabapp2 fabapp2 added the type: enhancement New feature or request label Mar 1, 2022
@timtebeek
Copy link
Contributor

Would adding a tool like Dependabot or Renovate be an option for this project? That could eliminate the need to explicitly upgrade dependencies by hand.. Looking through the list both of these properties are outdated:

  <openrewrite.version>7.16.3</openrewrite.version>
  <openrewrite.spring.version>4.14.1</openrewrite.spring.version>

The most recent versions as of writing are:

  <openrewrite.version>7.19.0</openrewrite.version>
  <openrewrite.spring.version>4.17.0</openrewrite.spring.version>

@fabapp2 fabapp2 mentioned this issue Mar 21, 2022
Closed
@fabapp2
Copy link
Contributor Author

fabapp2 commented Mar 21, 2022

Hi @timtebeek!
Thanks for your feedback. Dependabot is certainly a good idea (don't know Renovate yet), I added an issue.
But for this issue, it wouldn't help as this upgrade will require manual adjustments.

@fabapp2 fabapp2 changed the title Upgrade to OpenRewrite 7.18.2 Upgrade to OpenRewrite 7.19.0 Mar 23, 2022
@fabapp2 fabapp2 changed the title Upgrade to OpenRewrite 7.19.0 Upgrade to OpenRewrite 7.20.0 Mar 30, 2022
@fabapp2 fabapp2 linked a pull request Jun 21, 2022 that will close this issue
upgrade to openrewrite 7.22.0 #174
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabapp2 fabapp2

Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

upgrade to openrewrite 7.22.0 spring-projects-experimental/spring-boot-migrator
2 participants
@timtebeek @fabapp2