Skip to content

spring-boot-upgrade does not use correct port when it asks to open the report #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marcgemis opened this issue Jan 4, 2023 · 3 comments · Fixed by #717
Closed

spring-boot-upgrade does not use correct port when it asks to open the report #693

marcgemis opened this issue Jan 4, 2023 · 3 comments · Fixed by #717
Assignees
Labels
type: bug Something isn't working
Milestone

Comments

@marcgemis
Copy link

Describe the bug
When spring-boot-upgrade is started with a different port than 8080, it still asks to open the report on port 8080.

To Reproduce
Steps to reproduce the behavior:

  1. run spring-boot-upgrade with e.g. java -Dsbm.gitSupportEnabled=false -Dserver.port=8432 --add-opens java.base/sun.nio.ch=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED -jar spring-boot-upgrade.jar
  2. It executes and prints

/ | () | ___ \ | | |__ |
\ --. _ __ _ __ _ _ __ __ _ | |_/ / ___ ___ | |_ / / --. \ '_ | '| | '_ \ / ` | | ___ / _ \ / _ | __| \
/_
/ / |) | | | | | | | (| | | |/ / () | () | | .
/ /
_
/| ./|| ||| ||_, | _/ _/ _/ _| _/
| | / |
|| |
/


| | | | | | | ___ \ | |
| | | |_ __ __ _ _ __ __ _ | | ___ | |/ / _ __ ___ _ | |
| | | | '
\ / | '__/ _ |/ ` |/ _ \ | // _ \ ' \ / _ | '__| __|
| |
| | |) | (| | | | (| | (| | / | |\ \ / |) | () | | | |_
_/| .
/ _, || _,|_,|_| _| __| ./ _/|| _|
| | / | | |
|| |
/ |_|

powered by Spring Boot Migrator


Find us on GitHub: https://via.vmw.com/8AD63p

Please report all errors: https://via.vmw.com/bXlqJC


Scanning /Users/mgemis/Projects/p4/awp/bluecloud/microservices/eureka-server
finished scan. Please open: http://localhost:8080/spring-boot-upgrade

  1. while it is listening on port 8432

Expected behavior
The text should read
finished scan. Please open: http://localhost:8432/spring-boot-upgrade

Desktop (please complete the following information):

@marcgemis marcgemis changed the title spring-boot-upgrade does not use correct port when it asks to open the project spring-boot-upgrade does not use correct port when it asks to open the report Jan 4, 2023
@fabapp2 fabapp2 added type: bug Something isn't working type: enhancement New feature or request and removed type: enhancement New feature or request labels Jan 4, 2023
@fabapp2 fabapp2 self-assigned this Jan 4, 2023
@fabapp2 fabapp2 added this to the v0.14.0 milestone Jan 4, 2023
@fabapp2
Copy link
Contributor

fabapp2 commented Jan 4, 2023

Hi @marcgemis,
Valid point. Thanks for pointing this out. 🚀

@fabapp2 fabapp2 removed their assignment Feb 2, 2023
@fabapp2
Copy link
Contributor

fabapp2 commented Feb 2, 2023

@sanagaraj-pivotal do you want to look into this?

@sanagaraj-pivotal
Copy link
Contributor

@fabapp2 I can look into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
3 participants