Skip to content

3.0.0-M5: Redis Properties #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #440
fabapp2 opened this issue Sep 27, 2022 · 5 comments
Closed
Tracked by #440

3.0.0-M5: Redis Properties #443

fabapp2 opened this issue Sep 27, 2022 · 5 comments
Labels
3.0.0 Spring Boot 3.0.0 archived
Milestone

Comments

@fabapp2
Copy link
Contributor

fabapp2 commented Sep 27, 2022

labels: ["type: enhancement","good first issue","upgrade:boot-recipe","3.0.0"]

From the Release Notes

Configuration Properties for Redis have moved from spring.redis. to spring.data.redis. as redis auto-configuration requires Spring Data to be present on the classpath.

What needs to be done

Find all properties with prefix spring.redis. and change the property to use the prefix spring.data.redis..

This should be done as (integrated) declarative plain OpenRewrite recipe

See:

- type: org.springframework.sbm.engine.recipe.OpenRewriteDeclarativeRecipeAdapter
condition:
type: org.springframework.sbm.boot.common.conditions.IsSpringBootProject
versionPattern: "3\\.0\\..*"
description: Migrate SAML configuration to Spring Boot 3.0 in yaml format
openRewriteRecipe: |-
type: specs.openrewrite.org/v1beta/recipe
name: org.openrewrite.java.spring.boot2.SpringBootPropertiesManual_2_7
displayName: Migrate SAML configuration to Spring Boot 3.0 in yaml format
description: Renames spring.security.saml2.relyingparty.registration.(any).identityprovider to spring.security.saml2.relyingparty.registration.(any).assertingparty.
recipeList:
- org.openrewrite.yaml.ChangeKey:
oldKeyPath: $.spring.security.saml2.relyingparty.registration.*[?(@.identityprovider)]
newKey: assertingparty

@fabapp2 fabapp2 changed the title Redis Properties 3.0.0-M5: Redis Properties Sep 27, 2022
@fabapp2 fabapp2 added good first issue Good for newcomers upgrade-boot:migration 3.0.0 Spring Boot 3.0.0 type: enhancement New feature or request labels Sep 27, 2022
@fabapp2 fabapp2 added this to the v0.13.0 milestone Sep 27, 2022
@kuldeepsidhu88
Copy link

@fabapp2 I can work on this. Can you please assign this to me.

@fabapp2
Copy link
Contributor Author

fabapp2 commented Nov 3, 2022

Hi @kuldeepsidhu88

First of all, thanks for contributing to SBM 🚀

OpenRewrite has recently solved the problem of reading property changes from metadata information contained in jars.
Property changes in Spring Boot are documented in a spring-configuration-metadata.json file and they read them from the jars of the relevant version to create property update recipes out of these files.
This means we'd be reinventing the wheel with more recipes for property updates.

I haven't yet looked into it in detail but I guess I'll need to upgrade to the latest Rewrite to use their solution for migration recipes. That's on my list and I'd like to wait and see if we can reuse their recipe before we provide more of these recipes ourselves.

We decided to go "report-first" for now, so these changes should also be provided in a report (first).
I would like to see if we can use a similar (or even their) approach to generate the report section(s) that highlight relevant property changes in the report to users. If this works we could skip all property updates (migration & report) and generate them from the metadata information.

Looking at your timestamp makes me think we're in different time zones. Meaning I will try to provide more issues (and probably close some old ones) to reflect our "report-first" approach in the (currently bit messy) backlog today (🤞).
I am still lacking behind but I will try to provide an issue that would be more important at the moment, hoping you might be willing to look into it instead. (🤞)

@kuldeepsidhu88
Copy link

Sure @fabapp2
Please let me know which issue can be picked next, I would be happy to contribute.

@fabapp2
Copy link
Contributor Author

fabapp2 commented Nov 8, 2022

Hi @kuldeepsidhu88

I am starting to clean up the backlog.
If you like, #248 would be something to look into. I am still experimenting with an unified issue format for creating report sections and migrations of changes described in the Release Notes but I hope provided information is sufficient for a start 🤞

@kuldeepsidhu88
Copy link

@fabapp2 Okay, I will start looking into #248

@fabapp2 fabapp2 modified the milestones: v0.13.0, v0.14.0 Dec 1, 2022
@fabapp2 fabapp2 modified the milestones: v0.14.0, v0.15.0 Feb 21, 2023
@fabapp2 fabapp2 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 31, 2023
@fabapp2 fabapp2 added archived and removed type: enhancement New feature or request good first issue Good for newcomers upgrade:boot-recipe labels Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0.0 Spring Boot 3.0.0 archived
Projects
None yet
Development

No branches or pull requests

2 participants