Skip to content

Recipe AddRepositoryAction doesn't check condition NoRepositoryExistsCondition #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ashakirin opened this issue Jul 20, 2022 · 1 comment
Labels
type: enhancement New feature or request
Milestone

Comments

@ashakirin
Copy link
Contributor

ashakirin commented Jul 20, 2022

The Recipe AddRepositoryAction has the following condition configuration:

      description: Add Spring Boot milestone repository.
      id: "spring-milestone"
      url: "https://repo.spring.io/milestone"
      snapshotsEnabled: false
      condition:
        type: org.springframework.sbm.build.migration.conditions.NoRepositoryExistsCondition
        id: "spring-milestone"
        url: "https://repo.spring.io/milestone"

However recipe generates doubled spring-milestone repository entry, if it already exists in pom before:

		<repository>
			<id>spring-milestone</id>
			<url>https://repo.spring.io/milestone</url>
			<snapshots>
				<enabled>false</enabled>
			</snapshots>
		</repository>
		<repository>
			<id>spring-release</id>
			<url>https://repo.spring.io/release</url>
			<snapshots>
				<enabled>false</enabled>
			</snapshots>
		</repository>
		<repository>
			<id>spring-milestone</id>
			<url>https://repo.spring.io/milestone</url>
		</repository>
@ashakirin
Copy link
Contributor Author

Fixed with #243

@fabapp2 fabapp2 added this to the v0.12.0 milestone Sep 20, 2022
@fabapp2 fabapp2 added the type: enhancement New feature or request label Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants