Skip to content

Commit b32a639

Browse files
committed
It all works (kind of)
1 parent 98dbbb1 commit b32a639

File tree

7 files changed

+15
-66
lines changed

7 files changed

+15
-66
lines changed

components/jaxrs-recipes/pom.xml

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -109,11 +109,6 @@
109109
</exclusion>
110110
</exclusions>
111111
</dependency>
112-
<!-- <dependency>-->
113-
<!-- <groupId>org.springframework.sbm</groupId>-->
114-
<!-- <artifactId>sbm-support-boot</artifactId>-->
115-
<!-- <version>0.15.2-SNAPSHOT</version>-->
116-
<!-- </dependency>-->
117112

118113
<dependency>
119114
<groupId>com.tngtech.archunit</groupId>
@@ -206,12 +201,6 @@
206201
<version>8.29.0</version>
207202
<scope>test</scope>
208203
</dependency>
209-
<!-- <dependency>-->
210-
<!-- <groupId>org.junit-pioneer</groupId>-->
211-
<!-- <artifactId>junit-pioneer</artifactId>-->
212-
<!-- <version>2.1.0</version>-->
213-
<!-- <scope>test</scope>-->
214-
<!-- </dependency>-->
215204

216205
</dependencies>
217206
<build>

components/jaxrs-recipes/src/main/java/example/recipe/SbmAdapterRecipe.java

Lines changed: 8 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -92,13 +92,11 @@ public TreeVisitor<?, ExecutionContext> getScanner(List<SourceFile> acc) {
9292

9393
@Override
9494
public Collection<? extends SourceFile> generate(List<SourceFile> generate, ExecutionContext executionContext) {
95-
// Collection<? extends SourceFile> generate = super.generate(acc, executionContext);
96-
9795
// create the required classes
98-
initBeans(executionContext);
96+
initBeans();
9997

10098
// transform nodes to SourceFiles
101-
List<SourceFile> sourceFiles = generate.stream().filter(SourceFile.class::isInstance).map(SourceFile.class::cast).toList();
99+
List<SourceFile> sourceFiles = generate;
102100

103101
// FIXME: base dir calculation is fake
104102
Path baseDir = Path.of(".").resolve("testcode/jee/jaxrs/bootify-jaxrs/given").toAbsolutePath().normalize(); //executionContext.getMessage("base.dir");
@@ -114,61 +112,19 @@ public Collection<? extends SourceFile> generate(List<SourceFile> generate, Exec
114112
RewriteRecipeLoader recipeLoader = new RewriteRecipeLoader();
115113
new MigrateJaxRsRecipe().jaxRs(recipeLoader).apply(pc);
116114

117-
// Merge back result
118-
List<? extends SourceFile> modifiedNodes = merge(sourceFiles, pc.getProjectResources());
119-
120-
return modifiedNodes;
121-
}
122-
123-
private List<? extends SourceFile> merge(List<SourceFile> nodes, ProjectResourceSet projectResources) {
124-
// merge the changed results into the given list and return the result
125-
ArrayList<SourceFile> merged = new ArrayList<>();
126-
merged.addAll(nodes);
127-
projectResources.stream()
128-
.filter(r -> r.hasChanges())
129-
.forEach(changed -> {
130-
int pos = findPosition(merged, changed);
131-
merged.add(pos, changed.getSourceFile());
132-
});
133-
return merged;
134-
}
115+
List<? extends SourceFile> list = pc.getProjectResources().stream()
116+
.map(pr -> pr.getSourceFile())
117+
.toList();
135118

136-
private int findPosition(List<SourceFile> merged, RewriteSourceFileHolder<? extends SourceFile> changed) {
137-
List<String> paths = merged.stream().map(f -> f.getSourcePath().toString()).toList();
138-
return paths.indexOf(changed.getSourcePath().toString());
119+
return list;
139120
}
140121

141-
142-
private void initBeans(ExecutionContext executionContext) {
122+
private void initBeans() {
123+
// ExecutionContext is not retrieved from OpenRewrite here
143124
AnnotationConfigApplicationContext ctx = new AnnotationConfigApplicationContext("org.springframework.freemarker", "org.springframework.sbm", "org.springframework.rewrite");
144125
ctx.register(Configuration.class);
145126
this.projectContextFactory = ctx.getBean(ProjectContextFactory.class);
146127
this.projectResourceSetFactory = ctx.getBean(ProjectResourceSetFactory.class);
147-
// RewriteSourceFileWrapper sourceFileWrapper = new RewriteSourceFileWrapper();
148-
// SbmApplicationProperties sbmApplicationProperties = new SbmApplicationProperties();
149-
// JavaParserBuilder parserBuilder = new JavaParserBuilder();
150-
// List<ProjectResourceWrapper> projectResourceWrappers = new ArrayList<>();
151-
// RewriteMigrationResultMerger merger = new RewriteMigrationResultMerger(sourceFileWrapper);
152-
// ProjectResourceSetHolder holder = new ProjectResourceSetHolder(executionContext, merger);
153-
// JavaRefactoringFactory refactoringFactory = new JavaRefactoringFactoryImpl(holder, executionContext);
154-
// projectResourceWrappers.add(new JavaSourceProjectResourceWrapper(refactoringFactory, parserBuilder, executionContext));
155-
// ProjectMetadata projectMetadata = new ProjectMetadata();
156-
// MavenBuildFileRefactoringFactory buildFileRefactoringFactory = new MavenBuildFileRefactoringFactory(holder, new RewriteMavenParser(new MavenSettingsInitializer(executionContext, projectMetadata), executionContext), executionContext);
157-
// projectResourceWrappers.add(new BuildFileResourceWrapper(
158-
// event -> System.out.println(event),
159-
// buildFileRefactoringFactory,
160-
// executionContext,
161-
// new RewriteMavenArtifactDownloader(new LocalMavenArtifactCache(Path.of(System.getProperty("user.dir")).resolve(".m2/repository")), new MavenSettings(), t -> {throw new RuntimeException(t);}))
162-
// );
163-
//
164-
//
165-
// projectResourceSetFactory = new ProjectResourceSetFactory(new RewriteMigrationResultMerger(sourceFileWrapper), sourceFileWrapper, executionContext);
166-
// ProjectResourceWrapperRegistry registry = new ProjectResourceWrapperRegistry(projectResourceWrappers);
167-
// BasePackageCalculator calculator = new BasePackageCalculator(sbmApplicationProperties);
168-
//
169-
// ProjectResourceSetFactory resourceSetFactory = new ProjectResourceSetFactory(merger, sourceFileWrapper, executionContext);
170-
//
171-
// projectContextFactory = new ProjectContextFactory(registry, holder, refactoringFactory, calculator, parserBuilder, executionContext, merger, resourceSetFactory);
172128
}
173129

174130
}

components/jaxrs-recipes/src/main/java/org/springframework/sbm/FreemarkerConfiguration.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
*/
1616
package org.springframework.sbm;
1717

18+
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
1819
import org.springframework.context.annotation.Bean;
1920
import org.springframework.context.annotation.Configuration;
2021

@@ -24,6 +25,7 @@
2425
@Configuration
2526
public class FreemarkerConfiguration {
2627
@Bean
28+
@ConditionalOnMissingBean(type = "freemarker.template.Configuration")
2729
public freemarker.template.Configuration configuration() {
2830
return new freemarker.template.Configuration();
2931
}

components/jaxrs-recipes/src/main/java/org/springframework/sbm/UserInteractionsDummy.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,12 @@
1515
*/
1616
package org.springframework.sbm;
1717

18+
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
1819
import org.springframework.sbm.engine.recipe.UserInteractions;
1920
import org.springframework.stereotype.Component;
2021

2122
@Component
23+
@ConditionalOnMissingBean(type = "org.springframework.sbm.UserInteractions")
2224
public class UserInteractionsDummy implements UserInteractions {
2325
@Override
2426
public boolean askUserYesOrNo(String question) {

components/jaxrs-recipes/src/test/java/org/springframework/sbm/JaxRsThroughAdapterTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ void jaxRsRecipesThroughAdapterInOpenrewrite(@TempDir Path tmpDir) throws IOExce
300300
FileUtils.forceMkdir(to.toFile());
301301
FileUtils.copyDirectory(from.toFile(), to.toFile());
302302

303-
String mavenPluginVersion = "";
303+
String mavenPluginVersion = "5.35.0";
304304
String gradlePluginVersion = "";
305305
Path baseDir = tmpDir;
306306
// mvn -B --fail-at-end -Drewrite.activeRecipes=example.recipe.SbmAdapterRecipe -Drewrite.recipeArtifactCoordinates=org.springframework.sbm:jaxrs-recipes:0.15.2-SNAPSHOT -Dmaven.opts="-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=127.0.0.1:8000" org.openrewrite.maven:rewrite-maven-plugin:5.32.1:dryRun

components/jaxrs-recipes/src/test/java/org/springframework/sbm/jee/jaxrs/recipes/BootifyJaxRsAnnotationsRecipeTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ void test() {
3636
Optional<Recipe> recipe = Optional.of(jaxRsRecipe);
3737
RecipeTestSupport.assertThatRecipeExists(recipe);
3838
RecipeTestSupport.assertThatRecipeHasActions(recipe,
39-
AddDependencies.class,
39+
// AddDependencies.class,
4040
ConvertJaxRsAnnotations.class,
4141
ReplaceTypeAction.class,
4242
ReplaceTypeAction.class,

components/recipe-test-support/src/main/java/org/springframework/sbm/test/UserInteractionsDummy.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
import org.springframework.sbm.engine.recipe.UserInteractions;
1919
import org.springframework.stereotype.Component;
2020

21-
@Component
21+
//@Component
2222
public class UserInteractionsDummy implements UserInteractions {
2323
@Override
2424
public boolean askUserYesOrNo(String question) {

0 commit comments

Comments
 (0)