Skip to content

Commit a7987fb

Browse files
Fixing PagingAndSortingHelperTest conforming to new finder (#556)
1 parent f1eebe2 commit a7987fb

File tree

2 files changed

+28
-3
lines changed

2 files changed

+28
-3
lines changed

components/sbm-core/src/test/java/org/springframework/sbm/project/resource/TestProjectContext.java

Lines changed: 23 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -466,11 +466,14 @@ public ProjectContext build() {
466466
" <artifactId>dummy-root</artifactId>\n" +
467467
" <version>0.1.0-SNAPSHOT</version>\n" +
468468
" <packaging>jar</packaging>\n" +
469-
"{{}}\n" +
469+
"{{springParentPom}}\n" +
470470
"{{dependencies}}\n" +
471471
"</project>\n";
472472

473-
xml = xml.replace("{{dependencies}}", getDependenciesSection());
473+
xml = xml
474+
.replace("{{dependencies}}", getDependenciesSection())
475+
.replace("{{springParentPom}}", getSpringParentPomSection())
476+
;
474477

475478
resourcesWithRelativePaths.put(Path.of("pom.xml"), xml);
476479

@@ -520,6 +523,7 @@ public ProjectContext build() {
520523
return projectContext;
521524
}
522525

526+
523527
private void orderByOrderAnnotationValue(List<ProjectResourceWrapper> resourceWrapperList) {
524528
resourceWrapperList.sort(Comparator.comparing(this::getOrder));
525529
}
@@ -618,6 +622,23 @@ private String getDependenciesSection() {
618622
return dependenciesSection.toString();
619623
}
620624

625+
@NotNull
626+
private String getSpringParentPomSection() {
627+
628+
if (this.springVersion.isPresent()) {
629+
return """
630+
<parent>
631+
<groupId>org.springframework.boot</groupId>
632+
<artifactId>spring-boot-starter-parent</artifactId>
633+
<version>%s</version>
634+
<relativePath/>
635+
</parent>
636+
""".formatted(this.springVersion.get());
637+
}
638+
639+
return "";
640+
}
641+
621642
public Builder withSpringBootParentOf(String springVersion) {
622643

623644
this.springVersion = Optional.of(springVersion);

components/sbm-recipes-boot-upgrade/src/test/java/org/springframework/sbm/boot/upgrade_27_30/report/helper/PagingAndSortingHelperTest.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ public class A {}
4646
""";
4747

4848
ProjectContext context = TestProjectContext.buildProjectContext()
49+
.withSpringBootParentOf("2.7.1")
4950
.addJavaSource("src/main/java", javaClassWithPagingAndSortingRepository)
5051
.addJavaSource("src/main/java",javaClassWithoutPagingAndSortingRepo)
5152
.withBuildFileHavingDependencies("org.springframework.data:spring-data-commons:2.7.1")
@@ -105,6 +106,7 @@ public class A {}
105106
""";
106107

107108
ProjectContext context = TestProjectContext.buildProjectContext()
109+
.withSpringBootParentOf("2.7.1")
108110
.addJavaSource("src/main/java", javaClassWithReactiveSortingRepo)
109111
.addJavaSource("src/main/java",javaClassWithoutReactiveSortingRepo)
110112
.withBuildFileHavingDependencies("org.springframework.data:spring-data-commons:2.7.1")
@@ -165,7 +167,7 @@ public class A {}
165167
""";
166168

167169
ProjectContext context = TestProjectContext.buildProjectContext()
168-
.withSpringBootParentOf("2.7,1")
170+
.withSpringBootParentOf("2.7.1")
169171
.addJavaSource("src/main/java", javaClassWithReactiveSortingRepo)
170172
.addJavaSource("src/main/java",javaClassWithoutReactiveSortingRepo)
171173
.withBuildFileHavingDependencies("org.springframework.data:spring-data-commons:2.7.1")
@@ -250,6 +252,7 @@ public class A {}
250252
""";
251253

252254
ProjectContext context = TestProjectContext.buildProjectContext()
255+
.withSpringBootParentOf("2.7.1")
253256
.addJavaSource("src/main/java", javaClassWithPagingAndSortingRepository)
254257
.addJavaSource("src/main/java",javaClassWithoutPagingAndSortingRepo)
255258
.addJavaSource("src/main/java",javaClassWithReactiveSortingRepo)
@@ -309,6 +312,7 @@ public class A {}
309312
""";
310313

311314
ProjectContext context = TestProjectContext.buildProjectContext()
315+
.withSpringBootParentOf("2.7.1")
312316
.addJavaSource("src/main/java",javaClassWithoutPagingAndSortingRepo)
313317
.withBuildFileHavingDependencies("org.springframework.data:spring-data-commons:2.7.1")
314318
.build();

0 commit comments

Comments
 (0)