Skip to content

Commit 9dc1775

Browse files
authored
fixed #414 not found managed dependency
1 parent caab9e0 commit 9dc1775

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

applications/spring-shell/src/test/java/org/springframework/sbm/BootUpgrade_27_30_ManuallyManaged_IntegrationTest.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,6 @@ private void verifyManagedDependency(Xml.Document mavenAsXMLDocument, String art
7070
assertThat(managedDependency.get().getVersion()).isEqualTo(version);
7171
}
7272

73-
private void verifyDependency(Xml.Document mavenAsXMLDocument, String artifactId, String version) {
74-
verifyDependencyWithClassifier(mavenAsXMLDocument, artifactId, version, null);
75-
}
76-
7773
private void verifyDependencyWithClassifier(Xml.Document mavenAsXMLDocument, String artifactId, String version, String classifier) {
7874
Optional<Dependency> dependency = getDependencyByArtifactId(mavenAsXMLDocument, artifactId);
7975
assertThat(dependency).isPresent();

components/sbm-openrewrite/src/main/java/org/openrewrite/maven/spring/UpgradeUnmanagedSpringProject.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,8 +149,10 @@ public Xml.Tag visitTag(Xml.Tag tag, ExecutionContext executionContext) {
149149
Xml.Tag resultTag = super.visitTag(tag, executionContext);
150150
if (isManagedDependencyTag()) {
151151
ResolvedManagedDependency managedDependency = findManagedDependency(resultTag);
152-
String key = managedDependency.getGroupId() + ":" + managedDependency.getArtifactId();
153-
mayBeUpdateVersion(key, resultTag);
152+
if (managedDependency != null) {
153+
String key = managedDependency.getGroupId() + ":" + managedDependency.getArtifactId();
154+
mayBeUpdateVersion(key, resultTag);
155+
}
154156
}
155157
if (isDependencyTag()) {
156158
ResolvedDependency dependency = findDependency(resultTag);

0 commit comments

Comments
 (0)