Skip to content

Commit 98ba2fc

Browse files
authored
Merge branch 'version/revamp' into revamp/975-reciperun-differs-between-rewritemavenprojectparser-and-rewriteprojectparser
2 parents 9f86a90 + f8cac7c commit 98ba2fc

File tree

3 files changed

+19
-13
lines changed

3 files changed

+19
-13
lines changed

sbm-support-rewrite/src/main/resources/META-INF/sbm-support-rewrite.properties

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,4 +27,4 @@ parser.sizeThresholdMb=10
2727
parser.runPerSubmodule=false
2828
parser.failOnInvalidActiveRecipes=true
2929
parser.activeProfiles=default
30-
parser.ignoredPathPatterns=**.idea,**.git,**/target/**,target/**
30+
parser.ignoredPathPatterns=**.idea/**,**.git,**/target/**,target/**

sbm-support-rewrite/src/test/java/org/springframework/sbm/parsers/CompareParserRecipeRunTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,8 @@ public J.ClassDeclaration visitClassDeclaration(J.ClassDeclaration classDecl, Ex
103103
// Run Parser independent from Maven
104104
counter.setRelease(0);
105105
RecipeRun sutRecipeRun = recipe.run(new InMemoryLargeSourceSet(sutParsingResult.sourceFiles()), executionContext);
106-
assertThat(counter.get()).isEqualTo(2); // differs, should be 2
107-
assertThat(sutRecipeRun.getChangeset().getAllResults()).hasSize(1); // is 0
106+
assertThat(counter.get()).isEqualTo(2);
107+
assertThat(sutRecipeRun.getChangeset().getAllResults()).hasSize(1);
108108
}
109109

110110
}

sbm-support-rewrite/src/test/java/org/springframework/sbm/parsers/maven/RewriteMavenProjectParserIntegrationTest.java

+16-10
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,21 @@
1818
import org.junit.jupiter.api.DisplayName;
1919
import org.junit.jupiter.api.Test;
2020
import org.junitpioneer.jupiter.ExpectedToFail;
21+
import org.openrewrite.ExecutionContext;
22+
import org.openrewrite.InMemoryExecutionContext;
23+
import org.openrewrite.Parser;
24+
import org.openrewrite.SourceFile;
25+
import org.openrewrite.tree.ParsingEventListener;
26+
import org.openrewrite.tree.ParsingExecutionContextView;
2127
import org.springframework.beans.factory.annotation.Autowired;
2228
import org.springframework.boot.test.context.SpringBootTest;
2329
import org.springframework.boot.test.context.TestConfiguration;
2430
import org.springframework.context.event.EventListener;
2531
import org.springframework.sbm.boot.autoconfigure.SbmSupportRewriteConfiguration;
32+
import org.springframework.sbm.parsers.RewriteProjectParser;
2633
import org.springframework.sbm.parsers.RewriteProjectParsingResult;
2734
import org.springframework.sbm.parsers.events.FinishedParsingResourceEvent;
35+
import org.springframework.sbm.parsers.events.RewriteParsingEventListenerAdapter;
2836

2937
import java.nio.file.Path;
3038
import java.util.ArrayList;
@@ -49,7 +57,14 @@ public class RewriteMavenProjectParserIntegrationTest {
4957
void shouldPublishBuildEvents() {
5058

5159
Path baseDir = Path.of("./testcode/maven-projects/multi-module-1");
52-
RewriteProjectParsingResult parsingResult = sut.parse(baseDir);
60+
ExecutionContext executionContext = new InMemoryExecutionContext(t -> {throw new RuntimeException(t);});
61+
ParsingExecutionContextView.view(executionContext).setParsingListener(new ParsingEventListener() {
62+
@Override
63+
public void parsed(Parser.Input input, SourceFile sourceFile) {
64+
capturedEvents.add(new FinishedParsingResourceEvent(input, sourceFile));
65+
}
66+
});
67+
RewriteProjectParsingResult parsingResult = sut.parse(baseDir, executionContext);
5368
assertThat(capturedEvents).hasSize(3);
5469
assertThat(capturedEvents.get(0).sourceFile().getSourcePath().toString())
5570
.isEqualTo("pom.xml");
@@ -58,13 +73,4 @@ void shouldPublishBuildEvents() {
5873
assertThat(capturedEvents.get(2).sourceFile().getSourcePath().toString())
5974
.isEqualTo("module-a/pom.xml");
6075
}
61-
62-
@TestConfiguration
63-
static class TestEventListener {
64-
@EventListener(FinishedParsingResourceEvent.class)
65-
public void onEvent(FinishedParsingResourceEvent event) {
66-
capturedEvents.add(event);
67-
}
68-
}
69-
7076
}

0 commit comments

Comments
 (0)