Add Constructor Binding report

- defaultMap for shouldStartWith
- Add javadoc to TestProjectContext

Author: sanagaraj-pivotal

components/sbm-core/src/test/java/org/springframework/sbm/project/resource/TestProjectContext.java

@@ -320,6 +320,12 @@ public Builder addJavaSource(Path sourcePathDir, String sourceCode) {
             return this;
         }
 
+        /**
+         * Adds a Java source file to the {@code ProjectContext}.
+         *
+         * @param sourcePath e.g. {@code src/main/java} or {@code src/test/java} the package and classname are extracted from the given source code
+         * @param sourceCode the source code of the java file. It will be used to calculate package and classname.
+         */
         public Builder addJavaSource(String sourcePath, String sourceCode) {
             return addJavaSource(Path.of(sourcePath), sourceCode);
         }

components/sbm-recipes-boot-upgrade/pom.xml

@@ -67,6 +67,10 @@
             <artifactId>spring-asciidoctor-backends</artifactId>
             <version>${spring-asciidoctor-backends.version}</version>
         </dependency>
+        <dependency>
+            <groupId>org.openrewrite.recipe</groupId>
+            <artifactId>rewrite-spring</artifactId>
+        </dependency>
         <dependency>
             <groupId>org.springframework.boot</groupId>
             <artifactId>spring-boot-starter-test</artifactId>

components/sbm-recipes-boot-upgrade/src/main/java/org/springframework/sbm/boot/upgrade_27_30/report/helper/ConstructorBindingHelper.java

@@ -24,6 +24,7 @@
 import org.openrewrite.java.tree.J;
 import org.springframework.sbm.boot.upgrade_27_30.report.SpringBootUpgradeReportSection;
 import org.springframework.sbm.engine.context.ProjectContext;
+import org.springframework.sbm.engine.recipe.OpenRewriteSourceFilesFinder;
 import org.springframework.sbm.project.resource.RewriteSourceFileHolder;
 import org.springframework.sbm.support.openrewrite.GenericOpenRewriteRecipe;
 

components/sbm-recipes-boot-upgrade/src/test/java/org/springframework/sbm/boot/upgrade_27_30/report/ChangesToDataPropertiesReportTest.java

@@ -41,25 +41,25 @@ void changesToDataPropertiesSection_renders() {
                 .fromProjectContext(context)
                 .shouldRenderAs(
                         """
-                                    === Changes to Data Properties
-                                    Issue: https://github.com/spring-projects-experimental/spring-boot-migrator/issues/441[#441], Contributors: https://github.com/fabapp2[@fabapp2^, role="ext-link"]
-                                                                          
-                                    ==== What Changed
-                                    The data prefix has been reserved for Spring Data and any properties under the `data` prefix imply that Spring
-                                    Data is required on the classpath.
-                                                                          
-                                    ==== Why is the application affected
-                                    The scan found properties with `spring.data` prefix but no dependency matching `org.springframework.data:.*`.
-                                    
-                                    * file://<PATH>/src/main/resources/application.properties[`src/main/resources/application.properties`]
-                                    ** `spring.data.foo`
-                                    * file://<PATH>/src/main/resources/application-another.properties[`src/main/resources/application-another.properties`]
-                                    ** `spring.data.here`
-                                                       
-                                    ==== Remediation
-                                    Either add `spring-data` dependency, rename the property or remove it in case it's not required anymore.
-                                                                          
-                                    """);
+                        === Changes to Data Properties
+                        Issue: https://github.com/spring-projects-experimental/spring-boot-migrator/issues/441[#441], Contributors: https://github.com/fabapp2[@fabapp2^, role="ext-link"]
+                                                              
+                        ==== What Changed
+                        The data prefix has been reserved for Spring Data and any properties under the `data` prefix imply that Spring
+                        Data is required on the classpath.
+                                                              
+                        ==== Why is the application affected
+                        The scan found properties with `spring.data` prefix but no dependency matching `org.springframework.data:.*`.
+                        
+                        * file://<PATH>/src/main/resources/application.properties[`src/main/resources/application.properties`]
+                        ** `spring.data.foo`
+                        * file://<PATH>/src/main/resources/application-another.properties[`src/main/resources/application-another.properties`]
+                        ** `spring.data.here`
+                                           
+                        ==== Remediation
+                        Either add `spring-data` dependency, rename the property or remove it in case it's not required anymore.
+                                                              
+                        """);
     }
 
     @Test

components/sbm-recipes-boot-upgrade/src/test/java/org/springframework/sbm/boot/upgrade_27_30/report/SpringBootUpgradeReportTestSupport.java

@@ -91,7 +91,7 @@ public void shouldNotRender() {
         }
 
         public void shouldStartWith(String expectedOutput) {
-            shouldStartWith(expectedOutput, Map.of());
+            shouldStartWith(expectedOutput, defaultMap());
         }
 
         public void shouldStartWith(String expectedOutput, Map<String, String> templateVariables) {
@@ -159,7 +159,6 @@ public void writeReport(String s, Path outputDir, String filename) {
                     action.apply(reportBuilderData.getContext());
                 });
             } else if(SectionBuilderData.class.isInstance(builderData)) {
-                SectionBuilderData sectionBuilderData = SectionBuilderData.class.cast(builderData);
                 withRecipes(recipes -> {
                     Recipe recipe = recipes.getRecipeByName("boot-2.7-3.0-upgrade-report2").get();
                     SpringBootUpgradeReportAction action = (SpringBootUpgradeReportAction) recipe.getActions().get(0);

components/sbm-recipes-boot-upgrade/src/test/java/org/springframework/sbm/boot/upgrade_27_30/report/helper/ConstructorBindingHelperTest.java

@@ -17,7 +17,6 @@
 package org.springframework.sbm.boot.upgrade_27_30.report.helper;
 
 import org.intellij.lang.annotations.Language;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.springframework.sbm.boot.upgrade_27_30.report.SpringBootUpgradeReportTestSupport;
 import org.springframework.sbm.engine.context.ProjectContext;
@@ -64,10 +63,6 @@ public String getFrom() {
 
         ProjectContext context = TestProjectContext.buildProjectContext()
                 .addJavaSource("src/main/java", javaClassWithConstructorBinding)
-                .addJavaSource("src/main/java", """
-                        package com.example;
-                        public class A {}
-                        """)
                 .withBuildFileHavingDependencies("org.springframework.boot:spring-boot:2.7.1")
                 .build();
 
@@ -115,10 +110,5 @@ public class A { }
                 .addJavaSource("src/main/java/com/example/A.java", javaClassWithConstructorBinding)
                 .withBuildFileHavingDependencies("org.springframework.boot:spring-boot:2.7.1")
                 .build();
-
-        SpringBootUpgradeReportTestSupport
-                .generatedSection("Constructor Binding")
-                .fromProjectContext(context)
-                .shouldNotRender();
     }
 }