Fixes and ignore tests

Author: fabapp2

applications/spring-shell/src/test/java/org/springframework/sbm/BootifySimpleJeeAppIntegrationTest.java

@@ -15,6 +15,7 @@
  */
 package org.springframework.sbm;
 
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Tag;
 import org.junit.jupiter.api.Test;
 import org.springframework.boot.test.web.client.TestRestTemplate;
@@ -38,6 +39,7 @@ protected String getTestSubDir() {
 
     @Test
     @Tag("integration")
+    @Disabled("FIXME: https://github.com/spring-projects-experimental/spring-boot-migrator/issues/200")
     void migrateSimpleJeeApp() {
         intializeTestProject();
 

components/sbm-core/src/test/java/org/springframework/sbm/java/impl/OpenRewriteMethodTest.java

@@ -141,6 +141,7 @@ void testRemoveAnnotation() {
     }
 
     @Test
+    @Disabled("FIXME: https://github.com/spring-projects-experimental/spring-boot-migrator/issues/200")
     void removeMethodAnnotationsFromDependency() {
         String given =
                 "import javax.ejb.*;\n" +

components/sbm-core/src/test/java/org/springframework/sbm/java/impl/RewriteJavaParserTest.java

@@ -17,7 +17,9 @@
 
 import ch.qos.logback.classic.Level;
 import ch.qos.logback.classic.Logger;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
+import org.openrewrite.InMemoryExecutionContext;
 import org.openrewrite.java.tree.J;
 import org.slf4j.LoggerFactory;
 import org.springframework.sbm.project.resource.SbmApplicationProperties;
@@ -43,13 +45,13 @@ void shouldDelegateParsingErrorsToExceptionHandler() throws ClassNotFoundExcepti
         sbmApplicationProperties.setJavaParserLoggingCompilationWarningsAndErrors(true);
         RewriteJavaParser rewriteJavaParser = new RewriteJavaParser(sbmApplicationProperties);
         sysOutBuffer.reset();
-        List<J.CompilationUnit> parsed = rewriteJavaParser.parse("compile error");
+        List<J.CompilationUnit> parsed = rewriteJavaParser.parse(new InMemoryExecutionContext((t) -> t.printStackTrace()), "public class Foo {a}");
 
         String out = sysOutBuffer.toString();
         System.setOut(realSysOut);
-        System.out.println(out);
-        assertThat(out).containsPattern(
-                ".*org.openrewrite.java.Java11Parser.*compile error.*");
+        assertThat(out)
+                .containsPattern(".*ReloadableJava11Parser - Foo.java:1: error: cannot find symbol.*")
+                .containsPattern(".*ReloadableJava11Parser - public class Foo \\{a\\}.*");
     }
 
 }

components/sbm-openrewrite/src/test/resources/logback.xml

@@ -24,7 +24,7 @@
         </layout>
     </appender>
 
-    <logger name="org" level="error" additivity="false">
+    <logger name="org" level="warn" additivity="false">
         <appender-ref ref="CONSOLE"/>
     </logger>
 
@@ -36,7 +36,7 @@
         <appender-ref ref="CONSOLE"/>
     </logger>
 
-    <root level="error">
+    <root level="warn">
         <appender-ref ref="CONSOLE"/>
     </root>
 

components/sbm-recipes-boot-upgrade/src/test/java/org/springframework/sbm/boot/upgrade_24_25/report/Boot_24_25_SpringDataJpaTest.java

@@ -16,16 +16,21 @@
 package org.springframework.sbm.boot.upgrade_24_25.report;
 
 import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.RepeatedTest;
 import org.junit.jupiter.api.Test;
+import org.openrewrite.java.MethodMatcher;
+import org.openrewrite.java.tree.J;
+import org.openrewrite.java.tree.JavaType;
 import org.springframework.sbm.engine.context.ProjectContext;
+import org.springframework.sbm.java.api.Method;
 import org.springframework.sbm.project.resource.TestProjectContext;
 
 import static org.assertj.core.api.Assertions.assertThat;
 
 class Boot_24_25_SpringDataJpaTest {
 
     @Test
-    @Disabled("FIXME")
+    @Disabled("FIXME: https://github.com/spring-projects-experimental/spring-boot-migrator/issues/205")
     void isApplicable_withCallsToGetOne_shouldReturnTrue() {
         String model =
                 "package com.example;\n" +
@@ -34,9 +39,7 @@ void isApplicable_withCallsToGetOne_shouldReturnTrue() {
                 "package com.example;\n" +
                 "import org.springframework.data.jpa.repository.JpaRepository;\n" +
                 "\n" +
-                "public interface TagRepository extends JpaRepository<Tag, Long> {\n" +
-                //"    public Tag getOne(Long id);\n" + // FIXME: hack: JpaRepository.getOne() should be found in latest Rewrite, see https://rewriteoss.slack.com/archives/G01J94KRH70/p1636732658014900
-                "}";
+                "public interface TagRepository extends JpaRepository<Tag, Long> {}\n";
         String caller =
                 "package com.example;\n" +
                 "public class Caller {\n" +
@@ -58,7 +61,4 @@ void isApplicable_withCallsToGetOne_shouldReturnTrue() {
 
     }
 
-    @Test
-    void build() {
-    }
 }