Skip to content

Commit 490bed3

Browse files
committed
Back to use shrinkwrap in tests
1 parent 88f80a0 commit 490bed3

File tree

3 files changed

+38
-51
lines changed

3 files changed

+38
-51
lines changed

components/sbm-openrewrite/pom.xml

+8-21
Original file line numberDiff line numberDiff line change
@@ -74,27 +74,14 @@
7474
<groupId>org.projectlombok</groupId>
7575
<artifactId>lombok</artifactId>
7676
</dependency>
77-
<!-- <dependency>-->
78-
<!-- <groupId>org.jboss.shrinkwrap.resolver</groupId>-->
79-
<!-- <artifactId>shrinkwrap-resolver-spi</artifactId>-->
80-
<!-- </dependency>-->
81-
<!-- <dependency>-->
82-
<!-- <groupId>org.jboss.shrinkwrap.resolver</groupId>-->
83-
<!-- <artifactId>shrinkwrap-resolver-api-maven</artifactId>-->
84-
<!-- </dependency>-->
85-
<!-- <dependency>-->
86-
<!-- <groupId>org.jboss.shrinkwrap.resolver</groupId>-->
87-
<!-- <artifactId>shrinkwrap-resolver-spi-maven</artifactId>-->
88-
<!-- </dependency>-->
89-
<!-- <dependency>-->
90-
<!-- <groupId>org.jboss.shrinkwrap.resolver</groupId>-->
91-
<!-- <artifactId>shrinkwrap-resolver-impl-maven</artifactId>-->
92-
<!-- </dependency>-->
93-
<!-- <dependency>-->
94-
<!-- <groupId>org.jboss.shrinkwrap.resolver</groupId>-->
95-
<!-- <artifactId>shrinkwrap-resolver-bom</artifactId>-->
96-
<!-- <type>pom</type>-->
97-
<!-- </dependency>-->
77+
78+
<dependency>
79+
<groupId>org.jboss.shrinkwrap.resolver</groupId>
80+
<artifactId>shrinkwrap-resolver-depchain</artifactId>
81+
<version>${shrinkwrap.resolvers.version}</version>
82+
<type>pom</type>
83+
<scope>test</scope>
84+
</dependency>
9885

9986
<!-- FIXME: OR8.1 ClassNotFoundException: org.eclipse.aether.spi.synccontext.SyncContextFactory -->
10087
<dependency>

components/sbm-openrewrite/src/test/java/org/springframework/sbm/java/OpenRewriteTestSupport.java

+13-27
Original file line numberDiff line numberDiff line change
@@ -15,19 +15,16 @@
1515
*/
1616
package org.springframework.sbm.java;
1717

18-
import org.assertj.core.api.Assertions;
18+
import org.jboss.shrinkwrap.resolver.api.maven.Maven;
1919
import org.openrewrite.*;
2020
import org.openrewrite.internal.InMemoryLargeSourceSet;
21+
import org.springframework.sbm.java.util.JavaSourceUtil;
22+
import org.springframework.sbm.testhelper.common.utils.TestDiff;
23+
import org.assertj.core.api.Assertions;
2124
import org.openrewrite.java.JavaIsoVisitor;
2225
import org.openrewrite.java.JavaParser;
2326
import org.openrewrite.java.JavaVisitor;
2427
import org.openrewrite.java.tree.J;
25-
import org.openrewrite.maven.cache.LocalMavenArtifactCache;
26-
import org.openrewrite.maven.tree.ResolvedDependency;
27-
import org.openrewrite.maven.tree.ResolvedGroupArtifactVersion;
28-
import org.openrewrite.maven.utilities.MavenArtifactDownloader;
29-
import org.springframework.sbm.java.util.JavaSourceUtil;
30-
import org.springframework.sbm.testhelper.common.utils.TestDiff;
3128

3229
import java.io.File;
3330
import java.nio.file.Path;
@@ -39,7 +36,7 @@
3936
import java.util.stream.Collectors;
4037
import java.util.stream.Stream;
4138

42-
import static org.junit.jupiter.api.AssertionsKt.fail;
39+
import static org.junit.jupiter.api.Assertions.fail;
4340

4441

4542
public class OpenRewriteTestSupport {
@@ -238,27 +235,16 @@ public static JavaParser.Builder getJavaParser(String... classpath) {
238235
}
239236

240237
/**
241-
* Retrieve the <code>Path</code>s of jars for given gav
238+
* Retrieve the <code>Path</code>s of jars for given classpath
242239
*
243-
* @param gav in 'groupId:artifactId:version' format
240+
* @param classpath in 'groupId:artifactId:version' format
244241
*/
245-
public static List<Path> getClasspathFiles(String... gav) {
246-
if (gav.length == 0) return List.of();
247-
Path localM2 = Path.of(System.getProperty("user.home")).resolve(".m2/repository").normalize().toAbsolutePath();
248-
MavenArtifactDownloader mavenArtifactDownloader = new MavenArtifactDownloader(new LocalMavenArtifactCache(localM2), null, t -> {
249-
throw new RuntimeException(t);
250-
});
251-
return Arrays.stream(gav)
252-
.map(g -> g.split(":"))
253-
.map(g -> new ResolvedGroupArtifactVersion(null, g[0], g[1], g.length == 3 ? g[2] : null, null))
254-
.map(g -> ResolvedDependency.builder()
255-
.gav(g)
256-
.build()
257-
)
258-
.map(g -> {
259-
return mavenArtifactDownloader.downloadArtifact(g);
260-
})
261-
.toList();
242+
public static List<Path> getClasspathFiles(String... classpath) {
243+
if (classpath.length == 0) return List.of();
244+
File[] as = org.jboss.shrinkwrap.resolver.api.maven.Maven.resolver().resolve(classpath).withTransitivity().as(File.class);
245+
return Arrays.stream(as)
246+
.map(File::toPath)
247+
.collect(Collectors.toList());
262248
}
263249

264250
private static <P> RecipeRun refactor(J.CompilationUnit given, JavaVisitor<ExecutionContext> visitor) {

pom.xml

+17-3
Original file line numberDiff line numberDiff line change
@@ -219,16 +219,30 @@
219219
<version>4.3.4</version>
220220
<scope>compile</scope>
221221
</dependency>
222+
<dependency>
223+
<groupId>io.spring.asciidoctor.backends</groupId>
224+
<artifactId>spring-asciidoctor-backends</artifactId>
225+
<version>${spring-asciidoctor-backends.version}</version>
226+
</dependency>
222227
<dependency>
223228
<groupId>org.junit-pioneer</groupId>
224229
<artifactId>junit-pioneer</artifactId>
225230
<version>2.0.1</version>
226231
<scope>test</scope>
227232
</dependency>
228233
<dependency>
229-
<groupId>io.spring.asciidoctor.backends</groupId>
230-
<artifactId>spring-asciidoctor-backends</artifactId>
231-
<version>${spring-asciidoctor-backends.version}</version>
234+
<groupId>org.jboss.shrinkwrap.resolver</groupId>
235+
<artifactId>shrinkwrap-resolver-bom</artifactId>
236+
<version>${shrinkwrap.resolvers.version}</version>
237+
<scope>import</scope>
238+
<type>pom</type>
239+
</dependency>
240+
<dependency>
241+
<groupId>org.jboss.shrinkwrap.resolver</groupId>
242+
<artifactId>shrinkwrap-resolver-depchain</artifactId>
243+
<version>${shrinkwrap.resolvers.version}</version>
244+
<scope>test</scope>
245+
<type>pom</type>
232246
</dependency>
233247
</dependencies>
234248
</dependencyManagement>

0 commit comments

Comments
 (0)