Skip to content

Commit 12ee418

Browse files
bottemavfabapp2
authored andcommitted
Avoid NullPointerException in VisitorUtils.AdjustTypesFromExpressionMarkers
1 parent 9e76dbf commit 12ee418

File tree

1 file changed

+10
-6
lines changed
  • components/sbm-core/src/main/java/org/springframework/sbm/java/migration/visitor

1 file changed

+10
-6
lines changed

components/sbm-core/src/main/java/org/springframework/sbm/java/migration/visitor/VisitorUtils.java

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import org.openrewrite.java.JavaIsoVisitor;
2222
import org.openrewrite.java.JavaVisitor;
2323
import org.openrewrite.java.MethodMatcher;
24+
import org.openrewrite.java.tree.Expression;
2425
import org.openrewrite.java.tree.J;
2526
import org.openrewrite.java.tree.J.MethodDeclaration;
2627
import org.openrewrite.java.tree.J.MethodInvocation;
@@ -161,12 +162,15 @@ protected TreeVisitor<?, ExecutionContext> getVisitor() {
161162
@Override
162163
public Return visitReturn(Return _return, ExecutionContext p) {
163164
Return r = super.visitReturn(_return, p);
164-
MarkReturnType marker = r.getExpression().getMarkers().findFirst(MarkReturnType.class).orElse(null);
165-
if (marker != null) {
166-
removeMarker(r.getExpression(), marker);
167-
MethodDeclaration method = getCursor().firstEnclosing(MethodDeclaration.class);
168-
if (method != null) {
169-
doAfterVisit(new ChangeMethodReturnTypeRecipe(m -> m.getId().equals(method.getId()), marker.getExpression(), marker.getImports()));
165+
Expression expression = r.getExpression();
166+
if (expression != null) {
167+
MarkReturnType marker = expression.getMarkers().findFirst(MarkReturnType.class).orElse(null);
168+
if (marker != null) {
169+
removeMarker(expression, marker);
170+
MethodDeclaration method = getCursor().firstEnclosing(MethodDeclaration.class);
171+
if (method != null) {
172+
doAfterVisit(new ChangeMethodReturnTypeRecipe(m -> m.getId().equals(method.getId()), marker.getExpression(), marker.getImports()));
173+
}
170174
}
171175
}
172176
return r;

0 commit comments

Comments
 (0)