Skip to content

Commit 0ffb141

Browse files
315 refresh pom model after add repository (#344)
Co-authored-by: sanagaraj-pivotal <[email protected]>
1 parent 540227d commit 0ffb141

File tree

3 files changed

+14
-15
lines changed

3 files changed

+14
-15
lines changed

applications/spring-shell/src/test/resources/testcode/boot-migration-27-30/pom.xml

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -66,13 +66,6 @@
6666
<enabled>false</enabled>
6767
</snapshots>
6868
</repository>
69-
<!-- <repository>-->
70-
<!-- <id>spring-milestone</id>-->
71-
<!-- <url>https://repo.spring.io/milestone</url>-->
72-
<!-- <snapshots>-->
73-
<!-- <enabled>false</enabled>-->
74-
<!-- </snapshots>-->
75-
<!-- </repository>-->
7669
<repository>
7770
<id>spring-release</id>
7871
<url>https://repo.spring.io/release</url>
@@ -81,12 +74,7 @@
8174
</snapshots>
8275
</repository>
8376
</repositories>
84-
<pluginRepositories>
85-
<pluginRepository>
86-
<id>spring-milestone</id>
87-
<url>https://repo.spring.io/milestone</url>
88-
</pluginRepository>
89-
</pluginRepositories>
77+
9078
<build>
9179
<plugins>
9280
<plugin>

components/sbm-core/src/main/java/org/springframework/sbm/build/impl/OpenRewriteMavenBuildFile.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -713,8 +713,10 @@ public void excludeDependencies(List<Dependency> excludedDependencies) {
713713

714714
@Override
715715
public void addRepository(RepositoryDefinition repository) {
716-
AddMavenRepository addMavenRepository = new AddMavenRepository(repository);
717-
apply(addMavenRepository);
716+
Recipe recipe = new AddMavenRepository(repository)
717+
.doNext(new RefreshPomModel());
718+
719+
apply(recipe);
718720
}
719721

720722
@Override

components/sbm-core/src/test/java/org/springframework/sbm/build/migration/actions/AddRepositoryActionTest.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,16 @@ void shouldIgnoreRepositotyIfSameIdExists() {
241241
" </repositories>\n" +
242242
"</project>");
243243
}
244+
}
244245

246+
@Test
247+
public void shouldRefreshPomModel() {
248+
ProjectContext context = TestProjectContext.buildProjectContext().build();
249+
AddRepositoryAction sut = new AddRepositoryAction();
250+
sut.setUrl("my url");
251+
sut.setId("my id");
252+
sut.apply(context);
245253

254+
assertThat(context.getBuildFile().getRepositories()).hasSize(1);
246255
}
247256
}

0 commit comments

Comments
 (0)