Add withBootParentOf to TestProjectContext

- TestProjectContext supports creating pom.xml with spring-boot-parent of given version
- removed unused variable

Author: fabapp2

components/sbm-core/src/test/java/org/springframework/sbm/project/resource/TestProjectContext.java

@@ -249,6 +249,9 @@ public static class Builder {
         private OpenRewriteMavenBuildFile mockedBuildFile;
         private DependencyHelper dependencyHelper = new DependencyHelper();
         private SbmApplicationProperties sbmApplicationProperties = new SbmApplicationProperties();
+
+        private Optional<String> springVersion = Optional.empty();
+
         private JavaParser javaParser;
 
         public Builder(Path projectRoot) {
@@ -456,10 +459,22 @@ public ProjectContext serializeProjectContext(Path targetDir) {
         public ProjectContext build() {
             verifyValidBuildFileSetup();
 
-            if (dependencies != null && !dependencies.isEmpty()) {
-                String generatedPomXml = renderPomXmlWithGivenDependencies();
-                resourcesWithRelativePaths.put(Path.of("pom.xml"), generatedPomXml);
-            }
+            String xml = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n" +
+                    "<project xmlns=\"http://maven.apache.org/POM/4.0.0\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" xsi:schemaLocation=\"http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd\">\n" +
+                    "    <modelVersion>4.0.0</modelVersion>\n" +
+                    "{{springParentPom}}" +
+                    "    <groupId>com.example</groupId>\n" +
+                    "    <artifactId>dummy-root</artifactId>\n" +
+                    "    <version>0.1.0-SNAPSHOT</version>\n" +
+                    "    <packaging>jar</packaging>\n" +
+                    "{{dependencies}}" +
+                    "</project>\n";
+
+            xml = xml
+                    .replace("{{dependencies}}", getDependenciesSection())
+                    .replace("{{springParentPom}}", getSpringParentPomSection());
+
+            resourcesWithRelativePaths.put(Path.of("pom.xml"), xml);
 
             if (!containsAnyPomXml()) {
                 withDummyRootBuildFile();
@@ -588,22 +603,9 @@ private Parser.Input createParserInput(Path path, String value) {
 
 
         @NotNull
-        private String renderPomXmlWithGivenDependencies() {
-            String xml = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n" +
-                    "<project xmlns=\"http://maven.apache.org/POM/4.0.0\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" xsi:schemaLocation=\"http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd\">\n" +
-                    "    <modelVersion>4.0.0</modelVersion>\n" +
-                    "    <groupId>com.example</groupId>\n" +
-                    "    <artifactId>dummy-root</artifactId>\n" +
-                    "    <version>0.1.0-SNAPSHOT</version>\n" +
-                    "    <packaging>jar</packaging>\n" +
-                    "{{dependencies}}\n" +
-                    "</project>\n";
-
-            String dependenciesText = null;
-            if(dependencies.isEmpty()) {
-                dependenciesText = "";
-            } else {
-                StringBuilder dependenciesSection = new StringBuilder();
+        private String getDependenciesSection() {
+            StringBuilder dependenciesSection = new StringBuilder();
+            if(!dependencies.isEmpty()) {
                 dependenciesSection.append("    ").append("<dependencies>").append("\n");
                 dependencyHelper.mapCoordinatesToDependencies(dependencies).stream().forEach(dependency -> {
                     dependenciesSection.append("    ").append("    ").append("<dependency>").append("\n");
@@ -613,11 +615,32 @@ private String renderPomXmlWithGivenDependencies() {
                     dependenciesSection.append("    ").append("    ").append("</dependency>").append("\n");
                 });
                 dependenciesSection.append("    ").append("</dependencies>").append("\n");
-                dependenciesText = dependenciesSection.toString();
             }
 
-            String buildFileSource = xml.replace("{{dependencies}}", dependenciesText);
-            return buildFileSource;
+            return dependenciesSection.toString();
+        }
+
+        @NotNull
+        private String getSpringParentPomSection() {
+
+            if (this.springVersion.isPresent()) {
+                return """
+                            <parent>
+                                <groupId>org.springframework.boot</groupId>
+                                <artifactId>spring-boot-starter-parent</artifactId>
+                                <version>%s</version>
+                                <relativePath/>
+                            </parent>
+                        """.formatted(this.springVersion.get());
+            }
+
+            return "";
+        }
+
+        public Builder withSpringBootParentOf(String springVersion) {
+
+            this.springVersion = Optional.of(springVersion);
+            return this;
         }
     }
 

components/sbm-recipes-boot-upgrade/src/test/java/org/springframework/sbm/boot/upgrade_27_30/report/SpringBootUpgradeReportTestSupport.java

@@ -195,7 +195,6 @@ private void verify(Consumer<String> assertion) {
          * code of buttons to apply a recipe.
          */
         private String replaceRecipeButtonCodeFromExpectedOutput(SpringBootUpgradeReportSection sectionUnderTest, String renderedSection) {
-            StringBuilder sb = new StringBuilder();
             List<String> buttonCodes = new ArrayList<>();
             if(sectionUnderTest.getRemediation().getPossibilities().isEmpty()) {
                 String recipe = sectionUnderTest.getRemediation().getRecipe();

components/sbm-recipes-boot-upgrade/src/test/java/org/springframework/sbm/boot/upgrade_27_30/report/helper/PagingAndSortingHelperTest.java

@@ -165,6 +165,7 @@ public class A {}
         """;
 
         ProjectContext context = TestProjectContext.buildProjectContext()
+                .withSpringBootParentOf("2.7,1")
                 .addJavaSource("src/main/java", javaClassWithReactiveSortingRepo)
                 .addJavaSource("src/main/java",javaClassWithoutReactiveSortingRepo)
                 .withBuildFileHavingDependencies("org.springframework.data:spring-data-commons:2.7.1")