Fix issue 739, NPE

Paul Kelly · BoykoAlex · commit 087c26777478 · 2023-03-09T11:18:48.000-05:00
diff --git a/components/sbm-core/src/main/java/org/springframework/sbm/java/impl/OpenRewriteMethod.java b/components/sbm-core/src/main/java/org/springframework/sbm/java/impl/OpenRewriteMethod.java
@@ -164,7 +164,12 @@ public Optional<String> getReturnValue() {
             return Optional.empty();
         }
 
-        return Optional.of(TypeUtils.asFullyQualified(returnTypeExpression.getType()).getFullyQualifiedName());
+        JavaType.FullyQualified jfq = TypeUtils.asFullyQualified(returnTypeExpression.getType());
+        if (jfq == null) {
+            return Optional.empty();
+        } else {
+            return Optional.of(jfq.getFullyQualifiedName());
+        }
     }
 
     // FIXME: renaming method should not require a methodPattern in this context

Original file line number	Diff line number	Diff line change
`@@ -164,7 +164,12 @@ public Optional<String> getReturnValue() {`
`164`	`164`	`return Optional.empty();`
`165`	`165`	`}`
`166`	`166`
`167`		`- return Optional.of(TypeUtils.asFullyQualified(returnTypeExpression.getType()).getFullyQualifiedName());`
	`167`	`+ JavaType.FullyQualified jfq = TypeUtils.asFullyQualified(returnTypeExpression.getType());`
	`168`	`+ if (jfq == null) {`
	`169`	`+ return Optional.empty();`
	`170`	`+ } else {`
	`171`	`+ return Optional.of(jfq.getFullyQualifiedName());`
	`172`	`+ }`
`168`	`173`	`}`
`169`	`174`
`170`	`175`	`// FIXME: renaming method should not require a methodPattern in this context`