You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Signing the contributor's agreement does not grant anyone commit rights to the main
139
-
repository, but it does mean that we can accept your contributions, and you will get an
140
-
author credit if we do. Active contributors might be asked to join the core team, and
141
-
given the ability to merge pull requests.
142
-
143
-
=== Code of Conduct
144
-
This project adheres to the Contributor Covenant https://github.com/spring-cloud/spring-cloud-build/blob/master/docs/src/main/asciidoc/code-of-conduct.adoc[code of
145
-
conduct]. By participating, you are expected to uphold this code. Please report
* Make sure all new `.java` files to have a simple Javadoc class comment with at least an
160
-
`@author` tag identifying you, and preferably at least a paragraph on what the class is
161
-
for.
162
-
* Add the ASF license header comment to all new `.java` files (copy from existing files
163
-
in the project)
164
-
* Add yourself as an `@author` to the .java files that you modify substantially (more
165
-
than cosmetic changes).
166
-
* Add some Javadocs and, if you change the namespace, some XSD doc elements.
167
-
* A few unit tests would help a lot as well -- someone has to do it.
168
-
* If no-one else is using your branch, please rebase it against the current master (or
169
-
other target branch in the main project).
170
-
* When writing a commit message please follow https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html[these conventions],
171
-
if you are fixing an existing issue please add `Fixes gh-XXXX` at the end of the commit
172
-
message (where XXXX is the issue number).
173
-
174
-
=== Checkstyle
175
-
176
-
Spring Cloud Build comes with a set of checkstyle rules. You can find them in the `spring-cloud-build-tools` module. The most notable files under the module are:
177
-
178
-
.spring-cloud-build-tools/
179
-
----
180
-
└── src
181
-
├── checkstyle
182
-
│ └── checkstyle-suppressions.xml <3>
183
-
└── main
184
-
└── resources
185
-
├── checkstyle-header.txt <2>
186
-
└── checkstyle.xml <1>
187
-
----
188
-
<1> Default Checkstyle rules
189
-
<2> File header setup
190
-
<3> Default suppression rules
191
-
192
-
==== Checkstyle configuration
193
-
194
-
Checkstyle rules are *disabled by default*. To add checkstyle to your project just define the following properties and plugins.
<4> Add the Spring Java Format plugin that will reformat your code to pass most of the Checkstyle formatting rules
232
-
<5> Add checkstyle plugin to your build and reporting phases
233
-
234
-
If you need to suppress some rules (e.g. line length needs to be longer), then it's enough for you to define a file under `${project.root}/src/checkstyle/checkstyle-suppressions.xml` with your suppressions. Example:
It's advisable to copy the `${spring-cloud-build.rootFolder}/.editorconfig` and `${spring-cloud-build.rootFolder}/.springformat` to your project. That way, some default formatting rules will be applied. You can do so by running this script:
In order to setup Intellij you should import our coding conventions, inspection profiles and set up the checkstyle plugin.
260
-
The following files can be found in the https://github.com/spring-cloud/spring-cloud-build/tree/master/spring-cloud-build-tools[Spring Cloud Build] project.
261
-
262
-
.spring-cloud-build-tools/
263
-
----
264
-
└── src
265
-
├── checkstyle
266
-
│ └── checkstyle-suppressions.xml <3>
267
-
└── main
268
-
└── resources
269
-
├── checkstyle-header.txt <2>
270
-
├── checkstyle.xml <1>
271
-
└── intellij
272
-
├── Intellij_Project_Defaults.xml <4>
273
-
└── Intellij_Spring_Boot_Java_Conventions.xml <5>
274
-
----
275
-
<1> Default Checkstyle rules
276
-
<2> File header setup
277
-
<3> Default suppression rules
278
-
<4> Project defaults for Intellij that apply most of Checkstyle rules
279
-
<5> Project style conventions for Intellij that apply most of Checkstyle rules
Go to `File` -> `Settings` -> `Editor` -> `Code style`. There click on the icon next to the `Scheme` section. There, click on the `Import Scheme` value and pick the `Intellij IDEA code style XML` option. Import the `spring-cloud-build-tools/src/main/resources/intellij/Intellij_Spring_Boot_Java_Conventions.xml` file.
Go to `File` -> `Settings` -> `Editor` -> `Inspections`. There click on the icon next to the `Profile` section. There, click on the `Import Profile` and import the `spring-cloud-build-tools/src/main/resources/intellij/Intellij_Project_Defaults.xml` file.
292
-
293
-
.Checkstyle
294
-
295
-
To have Intellij work with Checkstyle, you have to install the `Checkstyle` plugin. It's advisable to also install the `Assertions2Assertj` to automatically convert the JUnit assertions
Go to `File` -> `Settings` -> `Other settings` -> `Checkstyle`. There click on the `+` icon in the `Configuration file` section. There, you'll have to define where the checkstyle rules should be picked from. In the image above, we've picked the rules from the cloned Spring Cloud Build repository. However, you can point to the Spring Cloud Build's GitHub repository (e.g. for the `checkstyle.xml` : `https://raw.githubusercontent.com/spring-cloud/spring-cloud-build/master/spring-cloud-build-tools/src/main/resources/checkstyle.xml`). We need to provide the following variables:
300
-
301
-
- `checkstyle.header.file` - please point it to the Spring Cloud Build's, `spring-cloud-build-tools/src/main/resources/checkstyle-header.txt` file either in your cloned repo or via the `https://raw.githubusercontent.com/spring-cloud/spring-cloud-build/master/spring-cloud-build-tools/src/main/resources/checkstyle-header.txt` URL.
302
-
- `checkstyle.suppressions.file` - default suppressions. Please point it to the Spring Cloud Build's, `spring-cloud-build-tools/src/checkstyle/checkstyle-suppressions.xml` file either in your cloned repo or via the `https://raw.githubusercontent.com/spring-cloud/spring-cloud-build/master/spring-cloud-build-tools/src/checkstyle/checkstyle-suppressions.xml` URL.
303
-
- `checkstyle.additional.suppressions.file` - this variable corresponds to suppressions in your local project. E.g. you're working on `spring-cloud-contract`. Then point to the `project-root/src/checkstyle/checkstyle-suppressions.xml` folder. Example for `spring-cloud-contract` would be: `/home/username/spring-cloud-contract/src/checkstyle/checkstyle-suppressions.xml`.
304
-
305
-
IMPORTANT: Remember to set the `Scan Scope` to `All sources` since we apply checkstyle rules for production and test sources.
306
-
307
-
=== Duplicate Finder
308
-
309
-
Spring Cloud Build brings along the `basepom:duplicate-finder-maven-plugin`, that enables flagging duplicate and conflicting classes and resources on the java classpath.
310
-
311
-
==== Duplicate Finder configuration
312
-
313
-
Duplicate finder is *enabled by default* and will run in the `verify` phase of your Maven build, but it will only take effect in your project if you add the `duplicate-finder-maven-plugin` to the `build` section of the projecst's `pom.xml`.
For other properties, we have set defaults as listed in the https://github.com/basepom/duplicate-finder-maven-plugin/wiki[plugin documentation].
329
-
330
-
You can easily override them but setting the value of the selected property prefixed with `duplicate-finder-maven-plugin`. For example, set `duplicate-finder-maven-plugin.skip` to `true` in order to skip duplicates check in your build.
331
-
332
-
If you need to add `ignoredClassPatterns` or `ignoredResourcePatterns` to your setup, make sure to add them in the plugin configuration section of your project:
NOTE: Spring Cloud is released under the non-restrictive Apache 2.0 license. If you would like to contribute to this section of the documentation or if you find an error, please find the source code and issue trackers in the project at {github-project}[github].
0 commit comments